| Summary: | [webhob-poky/master] in clean builds, noexec tasks are reported as "covered" instead of "executed" | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] Toaster | Reporter: | Belen Barros Pena <belen.barros.pena> | ||||||||||
| Component: | toaster | Assignee: | Alexandru Damian <alexandru.damian> | ||||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||||
| Severity: | normal | ||||||||||||
| Priority: | Medium | CC: | alexandru.damian, belen.barros.pena, bluelightning, dvhart | ||||||||||
| Version: | unspecified | ||||||||||||
| Target Milestone: | 1.6 M1 | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | Multiple | ||||||||||||
| Whiteboard: | bitbake | ||||||||||||
| OS type for building Yocto: | --- | Type of Regression: | --- | ||||||||||
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |||||||||||
| Attachments: |
|
||||||||||||
|
Description
Belen Barros Pena
2013-10-09 13:37:56 UTC
dora-toaster:46814c99eed399b6dd9ff9e83260fefe79c23ec8 Now we have both: loads of executed noexec and also loads of covered noexec (see attached screenshots). See also, bug 5457 Created attachment 1602 [details]
executed-noexec.png
Created attachment 1603 [details]
covered-noexec.png
This is actually expected result, I'm not sure about what's the bug here. The NoExec flag is set by default to all tasks where no task type information is available. For tasks that don't execute, because they are Prebuilt or Covered, the task type will always be NoExec. NoExec should be read as explicitly setup and not a default value only when tasks are marked as Executed. (In reply to comment #4) > This is actually expected result, I'm not sure about what's the bug here. Well, you asked me to open it :) > > The NoExec flag is set by default to all tasks where no task type > information is available. Why would we have tasks where no task type information is available? Task types are prebuilt or executed, and we should know which for each task. > For tasks that don't execute, because they are > Prebuilt or Covered, the task type will always be NoExec. This is not what I understood. I thought NoExec tasks were the ones set to [noexec], like for gcc-cross do_package[noexec] = "1" do_packagedata[noexec] = "1" do_package_write_ipk[noexec] = "1" do_package_write_rpm[noexec] = "1" do_package_write_deb[noexec] = "1" > NoExec should be read as explicitly setup and not a default value only when > tasks are marked as Executed. I am not sure that will work: NoExec is NoExec as above, and it should come up only for Executed tasks. It seems to me NoExec for Executed tasks and NoExec for Prebuilt tasks as currently implemented mean 2 different things. We don't want the same label (noexec) to have 2 different meanings. It confuses things. After some deliberation, we have decided that: executed - noexec will have the script_type set to noexec covered / prebuilt - noexec will have a null script_type That way we don't mix the 2. *** Bug 5457 has been marked as a duplicate of this bug. *** Rather than null can we have an additional option "Unknown"? "Enum" type database fields shouldn't really be allowed to be null. (In reply to comment #8) > Rather than null can we have an additional option "Unknown"? "Enum" type > database fields shouldn't really be allowed to be null. Of course, but maybe instead of "unknown" we could use something that communicates the fact that the field doesn't apply to such tasks. Maybe 'not applicable'? If I see 'unknown' I am left wondering if it should have been known and got lost somehow. I guess I fixed this bug a while ago (see script type N/A) and forgot to mark it as such. Merged in origin/master and origin/dora-toaster Script type comes ok in master (1e084f9d755e3458d2f9863382fa3bb7877a146d), but not in dora-toaster (1182665de0da9a6e5fc77107f32a7fc1515029d0), where all Executed tasks have the script type set to N/A. Also, CPU and Disk I/O data are not showing in dora-toaster. I've attached screenshots. Created attachment 1651 [details]
script_type_master.png
Created attachment 1652 [details]
script_type_dora-toaster.png
Proposed dropping support for dora+toaster due to extra dependencies in master which make back-porting very difficult. Resolved in master:ba8506ee342a1a579ceb309f3f50285eaad84f25 We have dropped support for dora-toaster. verified in master:ba8506ee342a1a579ceb309f3f50285eaad84f25 |