Bug 5373

Summary: kernel-yocto::do_validate_kernel test for machine branch broken
Product: [Yocto Project Subprojects] Kernel Reporter: Ola Nilsson <ola.x.nilsson>
Component: linux-yoctoAssignee: Bruce Ashfield <bruce.ashfield>
Status: RESOLVED INVALID QA Contact:
Severity: normal    
Priority: Medium CC: poky.bs.watcher, poky.watcher, sgw
Version: unspecified   
Target Milestone: 1.5.1   
Hardware: All   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)

Description Ola Nilsson 2013-10-22 10:00:08 UTC 
In do_validate_kernel there is a test for whether the machine_branch exists. 
The test is whether the return value of git show-ref --verify is exactly one.
At least on my machine the return value is 128 when the branch does not exist.
Maybe the test should be whether the return value is not 0?
Comment 1 Darren Hart 2013-10-28 10:34:04 UTC 
Bruce, this looks like a valid report to me. Giving this one to you for the tooling.
Comment 2 Bruce Ashfield 2013-10-28 11:50:54 UTC 
No we really want to check for 1:

       --verify
           Enable stricter reference checking by requiring an exact ref path. Aside from returning an error code of 1, it will also print an error
           message if --quiet was not specified.


We can't target all versions of git at once, so I'm continuing to go with
the man page and recent sources.
Comment 3 Bruce Ashfield 2013-10-28 11:51:48 UTC 
I should add that if we can show a real tree, where this fails, and
either a cryptic error message comes out, or another check doesn't
catch the problem later, I'll revisit.