Bug 5627

Summary:	Detect and fail when S has been set incorrectly
Product:	[Build System, Metadata & Runtime] OE-Core	Reporter:	Paul Eggleton <bluelightning>
Component:	core	Assignee:	Petter <petter>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	Low	CC:	meta.mr.watcher, meta.watcher, petter
Version:	1.6
Target Milestone:	Future
Hardware:	All
OS:	Multiple
Whiteboard:
OS type for building Yocto:	---	Type of Regression:	---
Verified:		Documentation change:	No (bug/feature does not impact docs)

Description Paul Eggleton 2013-12-04 13:56:52 UTC

At the moment we end up creating S if it's not created by unpacking an archive or fetching a repository; this is not really ideal in the case where S hasn't been properly set to match where the source actually has been unpacked. Ideally, we should avoid creating S, and then we can know when S hasn't been set correctly because it won't exist, and then we can fail immediately with an appropriate error message telling the user they need to set S, rather than failing with odd errors in later tasks.

Comment 1 Petter 2015-01-02 23:42:04 UTC

After discussion with Paul the conclusion is that the fix probably should result in a warning (at least to start with). Since I already have found around 10 recipes with faulty $S (for example S=WORKDIR/$PN (default) instead of S=WORKDIR) in oe-core, you might assume that a lot of external layers have recipes with this problem as well and display an error and abort might be a bit to hard. At least until people have had the chance to clean this up.

Will try to fix faulty 'S' within the scope of this bug as well..

Comment 2 Petter 2015-01-06 21:34:20 UTC

WIP commits:
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=petmab/bug5627

Comment 3 Petter 2015-01-16 22:19:07 UTC

Send for upstream approval.

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=petmab/bug5627 (oe-core)

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=petmab/bug5627_m-y (meta-yocto)

Comment 4 Petter 2015-01-16 22:22:53 UTC

Verified by running:

$ bitbake world (with and without sstate)
$ bitbake world + archiver enabled
$ Manually build + rebuild of affected (changed S value) recipes.

Comment 5 Petter 2015-01-24 15:17:07 UTC

Fixed in cf72ede74d35746a10d0708942287548f9c72f30 (poky).

Removed Bug 4634 (https://bugzilla.yoctoproject.org/show_bug.cgi?id=4634) as a depend to this bug, since it's more 'related' than a depend..