| Summary: | Changing LICENSE_CREATE_PACKAGE doesn't always take effect | ||
|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] OE-Core | Reporter: | Chen Qi <Qi.Chen> |
| Component: | core | Assignee: | Ross Burton <ross.burton> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Medium | CC: | bluelightning, jessica.zhang, joshuagloe, liezhi.yang, meta.mr.watcher, meta.watcher, sgw, yi.zhao |
| Version: | 1.5 | ||
| Target Milestone: | 2.1 M3 | ||
| Hardware: | x86 | ||
| OS: | Multiple | ||
| Whiteboard: | |||
| OS type for building Yocto: | --- | Type of Regression: | --- |
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |
Nobody cares about this one. Close it. Stumbled on this when helping get docs written for the LICENSE_CREATE_PACKAGE variable in #8633 Patch on the list. Fixed in oe-core master 0450c74e36b5547e3e903fdabe0f52675ac94dea. |
problem ------- Enabling and disabling 'LICENSE_CREATE_PACKAGE' doesn't cause rerun of the packaging process. As a result, if this variable is first enabled when building an image, and is then disabled when rebuilding the image, the license packages (e.g. busybox-lic) are still installed into that image. This is obviously not desired. To reproduce, use the following steps: 1. set in local.conf: LICENSE_CREATE_PACKAGE = "1" COPY_LIC_MANIFEST = "1" COPY_LIC_DIRS = "1" 2. bitbake busybox 3. set in local.conf: # LICENSE_CREATE_PACKAGE = "1" # COPY_LIC_MANIFEST = "1" # COPY_LIC_DIRS = "1" 4. bitbake busybox Use the following command to verify that the license package is still required by the main busybox pacakge. rpm -qp --requires <path/to/busybox/rpm/package> | grep '\-lic' cause ----- The license copying process should be in do_install task instead of the do_package task. This is because that copying of license has effect on ${D} instead of ${PKGD}. //Chen Qi