Bug 5641

Summary: Sometimes the task is executed when the value of the field task_executed is false.
Product: [Build System, Metadata & Runtime] Toaster Reporter: Andreea Brandusa Proca <andreea.b.proca>
Component: toasterAssignee: Alexandru Damian <alexandru.damian>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: Medium CC: alexandru.damian, belen.barros.pena, cristiana.voicu
Version: unspecified   
Target Milestone: 1.6 M2   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)
Attachments:
Description Flags
log file for recipe dbus-1.6.10-r6.0: task do_unpack
none
database none

Description Andreea Brandusa Proca 2013-12-06 14:32:46 UTC 
Created attachment 1657 [details]
log file for recipe dbus-1.6.10-r6.0: task do_unpack

Task:
  {
        "pk": 2819,
        "model": "orm.task",
        "fields": {
            "work_directory": "",
            "cpu_usage": null,
            "task_executed": false,
            "disk_io": null,
            "line_number": 0,
            "path_to_sstate_obj": "",
            "sstate_checksum": "c6a3b6f809371a19bb11aec55c1b92cd",
            "recipe": 172,
            "sstate_result": 0,
            "source_url": "",
            "elapsed_time": "0.127917",
            "logfile": "/home/brandusa/masterT/build/tmp/work/mips32-poky-linux/dbus/1.6.10-r6.0/temp/log.do_unpack.13626",
            "build": 2,
            "task_name": "do_unpack",
            "message": "recipe dbus-1.6.10-r6.0: task do_unpack: Succeeded",
            "outcome": 0,
            "order": 210,
            "script_type": 2
        }

But the task is executed (as you can see in the task log file attached) and the outcome of the task is 0 (SUCCESS). 

In case an task is not executed the outcome should have the value COVERED,  SSTATE or EXISTING.

This problem appeared when building:

    {
        "pk": 2,
        "model": "orm.build",
        "fields": {
            "build_name": "201312051725",
            "outcome": 0,
            "completed_on": "2013-12-05T16:01:58.165Z",
            "warnings_no": 9,
            "distro_version": "1.5+snapshot-20131205",
            "started_on": "2013-12-05T15:25:50.935Z",
            "machine": "qemumips",
            "bitbake_version": "1.21.0",
           "cooker_log_path": "/home/brandusa/masterT/build/tmp/log/cooker/qemumips/20131205152452.log",
            "image_fstypes": "ext3 tar.bz2",
            "errors_no": 0,
            "distro": "poky-lsb"
        }

Tested on master:c51730aaa91066cfb51ad6ec2920fb4f9d9ea94c.
Comment 1 Andreea Brandusa Proca 2013-12-06 14:33:44 UTC 
Created attachment 1658 [details]
database
Comment 2 Belen Barros Pena 2014-02-13 12:33:00 UTC 
We also need to change the orm model to map 

task_executed = False

to the string "Not executed" so that we show the right string everywhere in the Toaster UI
Comment 3 Alexandru Damian 2014-02-13 16:32:08 UTC 
This bug has two parts:

- task success outcome with "task_executed" false; this is the same bug as 5763.
- updating the display of task_executed field. the patch is on contrib/adamian/fixes
Comment 4 Alexandru Damian 2014-02-21 14:32:24 UTC 
Merged.
Comment 5 Andreea Brandusa Proca 2014-03-19 08:23:26 UTC 
Verified in master:463cd34f8c17c67c4f3adf3468424730b22f3974