| Summary: | Not available outcome when task is not executed. | ||
|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] Toaster | Reporter: | Andreea Brandusa Proca <andreea.b.proca> |
| Component: | toaster | Assignee: | Alexandru Damian <alexandru.damian> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Medium | CC: | alexandru.damian, belen.barros.pena, bluelightning, cristiana.voicu |
| Version: | unspecified | ||
| Target Milestone: | 1.6 M4 | ||
| Hardware: | x86 | ||
| OS: | Multiple | ||
| Whiteboard: | |||
| OS type for building Yocto: | --- | Type of Regression: | --- |
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |
This works as intended. The design specifies that for NoExec tasks, the outcome is *empty*. Since we have to have a value there, the coding for *empty* is OUTCOME_NA, 'Not available' Not a bug. Right, that makes sense, but it is a bit confusing, particularly because "not available" used to mean a different thing, and because it seems to be the default value for the 'outcome' field outcome = models.IntegerField(choices=TASK_OUTCOME, default=OUTCOME_NA) If we are going to reuse OUTCOME_NA for the Not executed - Empty tasks, can we change the model to say (OUTCOME_NA, 'Empty') and can we make sure it is not the default value for the outcome field? I would actually suggest that this is UI implementation detail, and for OUTCOME_NA we should display actually nothing (empty box), instead of "Empty". What do you say ? (In reply to comment #3) > I would actually suggest that this is UI implementation detail, and for > OUTCOME_NA we should display actually nothing (empty box), instead of > "Empty". > > What do you say ? I don't think we should do that. "Empty" means that the task is empty in the sense that it doesn't have any executable content. "Empty" is the same as "Prebuilt" or "Covered": is the way we name a certain type of task in Toaster. Of all the possible labels we could come up with, we chose "Empty" as the least bad of them all. In a table where each and every task has an outcome, it would be quite strange to have noexec tasks without one. The outcomes are a classification system for BitBake tasks: to be effective as a classification system, they must cover all tasks without exception. I hope this makes sense. Needs label change. The changeset for implementing OUTCOME_EMPTY is merged into origin/master. Verified in master:ac4ff568f5b2ad4f50a1b7b60797e7b797c314bb |
{ "pk": 468,. "model": "orm.task",. "fields": { "work_directory": "",. "cpu_usage": null,. "task_executed": false,. "disk_io": null,. "line_number": 0,. "path_to_sstate_obj": "",. "sstate_checksum": "",. "recipe": 139,. "sstate_result": 0,. "source_url": "",. "elapsed_time": "0",. "logfile": "",. "build": 1,. "task_name": "do_package",. "message": "",. "outcome": 5,. "order": null,. "script_type": 0 } "outcome": 5 => from models.py: OUTCOME_NA = 5 and OUTCOME_NA = 'Not Available' master:1a9226f140f578f11696abf1a3c989fae1d4c14a