Bug 5795

Summary: avahi-daemon does not work correctly with lsb_log_message script
Product: [Build System, Metadata & Runtime] OE-Core Reporter: Cristian Iorga <cristian.iorga>
Component: connectivityAssignee: Cristian Iorga <cristian.iorga>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: Medium CC: corneliux.stoicescu, meta.mr.watcher, meta.watcher, sgw
Version: unspecified   
Target Milestone: 1.6 M5   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)

Description Cristian Iorga 2014-02-06 16:00:46 UTC
During boot, there are errors found in /var/log/boot related to avahi-daemon:

Thu Feb  6 10:54:51 2014: Starting Avahi mDNS/DNS-SD Daemon: avahi-daemon/etc/core-lsb/lsb_log_message: line 26: begin: command not found

This was tested with qemux86-64 QEMU machine, using master with commit:
82f9c2bcff3e977beefde6048d2ba32d17acbbd0.

Full log below:

root@qemux86-64:~# cat /var/log/boot 
Thu Feb  6 10:54:35 2014: bootlogd.
Thu Feb  6 10:54:35 2014: Populating dev cache
Thu Feb  6 10:54:43 2014: ALSA: Restoring mixer settings...
Thu Feb  6 10:54:43 2014: /usr/sbin/alsactl: load_state:1729: No soundcards found...
Thu Feb  6 10:54:43 2014: net.ipv4.conf.default.rp_filter = 1
Thu Feb  6 10:54:43 2014: net.ipv4.conf.all.rp_filter = 1
Thu Feb  6 10:54:43 2014: Starting atd: OK
Thu Feb  6 10:54:43 2014: INIT: Entering runlevel: 5
Thu Feb  6 10:54:43 2014: Configuring network interfaces... done.
Thu Feb  6 10:54:44 2014: Starting system message bus: dbus.
Thu Feb  6 10:54:44 2014: Starting OpenBSD Secure Shell server: sshd
Thu Feb  6 10:54:44 2014:   generating ssh RSA key...
Thu Feb  6 10:54:45 2014:   generating ssh ECDSA key...
Thu Feb  6 10:54:45 2014:   generating ssh DSA key...
Thu Feb  6 10:54:47 2014: done.
Thu Feb  6 10:54:47 2014: Starting rpcbind daemon...done.
Thu Feb  6 10:54:47 2014: creating NFS state directory: done
Thu Feb  6 10:54:47 2014: starting statd: done
Thu Feb  6 10:54:48 2014: Starting Distributed Compiler Daemon: distcc.
Thu Feb  6 10:54:49 2014: starting 8 nfsd kernel threads: rpc.nfsd: Setting version failed: errno 22 (Invalid argument)
Thu Feb  6 10:54:49 2014: done
Thu Feb  6 10:54:49 2014: starting mountd: done
Thu Feb  6 10:54:49 2014: Starting system log daemon...0
Thu Feb  6 10:54:50 2014: Starting kernel log daemon...0
Thu Feb  6 10:54:51 2014: Starting internet superserver: xinetd.
Thu Feb  6 10:54:51 2014: Starting Avahi mDNS/DNS-SD Daemon: avahi-daemon/etc/core-lsb/lsb_log_message: line 26: begin: command not found
Thu Feb  6 10:54:51 2014: 
Thu Feb  6 10:54:52 2014: Starting Lighttpd Web Server: lighttpd.
Thu Feb  6 10:54:52 2014: cupsd: Child exited with status 1
Thu Feb  6 10:54:52 2014: cups: unable to start scheduler.
Thu Feb  6 10:54:53 2014: Starting crond: OK
Thu Feb  6 10:54:53 2014: Starting OProfileUI server
Thu Feb  6 10:54:53 2014: 
root@qemux86-64:~# uname -a
Linux qemux86-64 3.10.25-yocto-standard #5 SMP PREEMPT Thu Feb 6 11:29:14 EET 2014 x86_64 GNU/Linux
root@qemux86-64:~# rpm -qa | grep mdns
libnss-mdns-0.10-r7.core2_64
root@qemux86-64:~# rpm -qa | grep avahi
libavahi-common3-0.6.31-r7.1.core2_64
libavahi-core7-0.6.31-r7.1.core2_64
libavahi-client3-0.6.31-r7.1.core2_64
avahi-daemon-0.6.31-r7.1.core2_64
libavahi-glib1-0.6.31-r7.1.core2_64
avahi-locale-en-gb-0.6.31-r7.1.core2_64
root@qemux86-64:~#
Comment 1 Cristian Iorga 2014-02-06 16:02:04 UTC
Investigated started.
Might be related to:
http://patches.openembedded.org/patch/60733/
Comment 2 Cristian Iorga 2014-03-26 13:46:52 UTC
LSB lsb_log_message calls a begin() function that should be implemented in /etc/init.d/functions. The aforementioned script does not implement the begin() function, as such there is a small issue related to logging.

However, the confusion seems to stem from the fact that the LSB standard does not properly states who should implement such functions and where.
Comment 3 Cristian Iorga 2014-03-26 13:49:09 UTC
Adding Ubuntu as an example, log_begin_msg is implemented directly in:
/lib/lsb/init-functions script:

# int log_begin_message (char *message)
log_begin_msg () {
    log_begin_msg_pre "$@"
    if [ -z "${1:-}" ]; then
        return 1
    fi
    echo -n "$@" || true
    log_begin_msg_post "$@"
}
 where:

# Pre&Post empty function declaration, to be overriden from /lib/lsb/init-functions.d/*
log_begin_msg_pre () { :; }
log_begin_msg_post () { :; }
Comment 4 Cristian Iorga 2014-03-27 07:16:02 UTC
Patch sent for review.
Comment 6 Stoicescu Cornel 2014-04-02 14:13:51 UTC
*** Bug 6103 has been marked as a duplicate of this bug. ***
Comment 7 Stoicescu Cornel 2014-04-03 14:37:10 UTC
Verified with poky master:3e528d3e4bc542ca2f654c54363c56af0fb9f61b