| Summary: | Add counters to filters | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] Toaster | Reporter: | Belen Barros Pena <belen.barros.pena> | ||||||
| Component: | toaster | Assignee: | Ravi Chintakunta <ravi.chintakunta> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | enhancement | ||||||||
| Priority: | Medium | CC: | alexandru.damian, belen.barros.pena, cristiana.voicu, jessica.zhang | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | 1.6 M4 | ||||||||
| Hardware: | All | ||||||||
| OS: | Multiple | ||||||||
| Whiteboard: | GUI design available | ||||||||
| OS type for building Yocto: | --- | Type of Regression: | --- | ||||||
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |||||||
| Attachments: |
|
||||||||
Since the filter is applied on the search results (if there is a search string), I believe that the count that is displayed for the various filters should be after the search is applied. Can you please confirm? And if so, should the filter dialog show that it is being applied on top of the search string. (In reply to comment #1) > Since the filter is applied on the search results (if there is a search > string), I believe that the count that is displayed for the various filters > should be after the search is applied. > > Can you please confirm? Yes, you are completely right. The counter should reflect the number of results that the filter will return at any given time. So if a filter is applied of top of a search string, the counter should update accordingly to show the numbers contained within the search results. > > And if so, should the filter dialog show that it is being applied on top of > the search string. This is a really good point. Maybe we could use the modal dialog heading. It could be like this: Filter <number_of_search_results> {{objectname|title}} matching '<search_string>' by '{{tc.name}} So, for example, if I searched my builds for the string '-minimal' and got 25 results, the filter heading for the Errors filter would say: Filter 25 Builds matching '_minimal' by 'Errors' I have attached an example. Created attachment 1801 [details]
Filter heading with search example
Pushed commit: http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/bug-fixes&id=6da9e0124b2e749755714d8d8320cfd3d7884f5c merged to master http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=1db32b097b5a4f305e056ae26b940be832efa7cf verified in master:ac4ff568f5b2ad4f50a1b7b60797e7b797c314bb |
Created attachment 1771 [details] Design - Filter counters Alex Damien has suggested to add a counter for each filter, so that you know at a glance the general distribution between the different categories and the number of items that will be returned by the filter. A nice side effect of the counter is that we can use it to disable the filter when the counter is 0, i.e. when it will return no results. Design spec attached