| Summary: | poky sdk version can't be decided simply by build date | ||
|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] Meta-yocto | Reporter: | liping Ke <liping.ke> |
| Component: | meta-yocto | Assignee: | Jessica <jessica.zhang> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Medium | CC: | jessica.zhang, josh, ke.yu, kevin.tian, lianhao.lu, poky.bs.watcher, poky.watcher, richard.purdie, sgw |
| Version: | 1.0 | ||
| Target Milestone: | 1.0 M3 | ||
| Hardware: | x86 | ||
| OS: | Multiple | ||
| Whiteboard: | |||
| OS type for building Yocto: | --- | Type of Regression: | --- |
| Verified: | Documentation change: | --- | |
|
Description
liping Ke
2010-12-12 22:57:14 UTC
The current DISTRO_VERSION is defined as "0.9+snapshot-${DATE}" in meta/conf/distro/poky.conf. This value is also used in SDKPATH to specify the SDK version. The ${DATE} would result the variable SDKPATH value due to the different building time.
or should we change it to the date of latest poky git commit? Hi, Ke Actually I think SDK version should be relatively stable. Only when we feel that new features added and SDK version should be added (eg, 1.0 released, or 1.0 update released), should we change the SDK version? I am not sure... criping (In reply to comment #2) > or should we change it to the date of latest poky git commit? Using DATE in the distro version is just an easy way to tell you are using a development build. I felt it made sense to use the distro version as the SDK version also as it make it easier to tell which distro the SDK was built for. As the proposed usage model for users is to develop against a stable release you could do wild card matching on the date element for development? Any way, I'm not especially attached to the SDK version I implemented. Just thought it worth explaining my reasoning. (In reply to comment #4) > Using DATE in the distro version is just an easy way to tell you are using a > development build. > I felt it made sense to use the distro version as the SDK version also as it > make it easier to tell which distro the SDK was built for. > As the proposed usage model for users is to develop against a stable release > you could do wild card matching on the date element for development? > Any way, I'm not especially attached to the SDK version I implemented. Just > thought it worth explaining my reasoning. when your reason is reasonable, I still think that we need a separate SDK_VERSION explicitly here. We can stamp it to distro version, or even use a wild card matching as you said or some other version schemes, but we do that under this new variable which makes things clear and more maintainable. :-) Since the DATE element is only included in the DISTRO_VERSION for development, then I'd suggest that our SDK_VERSION logic to be as:
If DISTRO_VERSION contains snapshot
SDK_VERSION = 0.9+snapshot (stripe off the date part)
Else
SDK_VERSION = DISTRO_VERSION (which means the DISTRO is a stablized and meaningful version, e.g. M3_RC1, etc, or 1.0 relrease, etc.)
SDKPATH = "/opt/${DISTRO}/${SDK_VERSION}"
This way we can easily link the SDK_VERSION to DISTRO_VERSION and avoid the unnecessary version issue during the development cycle...
Fixed and sent out pull request for http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jzhang/sdkversion |