| Summary: | 2 flaws in configuration page when no search result returned. | ||
|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] Toaster | Reporter: | Yuan Sun <Yuan.Sun2> |
| Component: | toaster | Assignee: | Belen Barros Pena <belen.barros.pena> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Medium | CC: | alexandru.damian, belen.barros.pena, cristiana.voicu, david.reyna, jessica.zhang |
| Version: | 1.6 | ||
| Target Milestone: | 1.6 M5 | ||
| Hardware: | x86 | ||
| OS: | Multiple | ||
| Whiteboard: | |||
| OS type for building Yocto: | --- | Type of Regression: | --- |
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |
|
Description
Yuan Sun
2014-03-19 07:05:38 UTC
(In reply to comment #0) > 2 flaws in configuration page when no search result returned. > (1) "No variables found" should be showed instead of "0 variables found". The fix for bug 5981, already submitted for review, fixes this problem http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=bbarrosp/fix-5981&id=6a554f16e0ccafd62c19b110ef61668d867ea3be > (2) "Search bitbake variables" should be showed in text input field, not the > previout search content. If I understand this correctly, the problem is that the no results page is showing the search string. This is, however, the correct behaviour, so that users know what they typed and can amend it and re-search as needed. > > tested in 1f16ca9fba325f5ddbb1edad5bbad78d990de5e0. (In reply to comment #1) > (In reply to comment #0) > > 2 flaws in configuration page when no search result returned. > > (1) "No variables found" should be showed instead of "0 variables found". > > The fix for bug 5981, already submitted for review, fixes this problem > > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=bbarrosp/ > fix-5981&id=6a554f16e0ccafd62c19b110ef61668d867ea3be > > > (2) "Search bitbake variables" should be showed in text input field, not the > > previout search content. > > If I understand this correctly, the problem is that the no results page is > showing the search string. This is, however, the correct behaviour, so that > users know what they typed and can amend it and re-search as needed. > > > > > tested in 1f16ca9fba325f5ddbb1edad5bbad78d990de5e0. See page 4 of https://bugzilla.yoctoproject.org/attachment.cgi?id=1754. "Search bitbake variables" should be showed in the text input field of "no search result" page.
> See page 4 of https://bugzilla.yoctoproject.org/attachment.cgi?id=1754.
> "Search bitbake variables" should be showed in the text input field of "no
> search result" page.
Very true: the documentation is wrong in this case
Patch was merged to master http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=4f44b8b95244efc1465a5c0f62b67e42e81dfc4e It is working everywhere except the variables table. Looking into it fix submitted for review http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=bbarrosp/fix-6001&id=49beb1ccac53c2922dec32e597d73efb5f7ef578 commit c07a294e30e09926a07081ebc275c1766304ce38 Verified in 3e528d3e4bc542ca2f654c54363c56af0fb9f61b. |