| Summary: | LPSS configuration help is misleading / inaccurate | ||
|---|---|---|---|
| Product: | [Hardware Platforms] MinnowBoard MAX Firmware | Reporter: | Darren Hart <dvhart> |
| Component: | minnowmax-edk2 | Assignee: | Darren Hart <dvhart> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Medium | CC: | mike.wu, sjolley.yp.pm, warthog9 |
| Version: | unspecified | ||
| Target Milestone: | A1 Release | ||
| Hardware: | MinnowBoard Max | ||
| OS: | Multiple | ||
| Whiteboard: | |||
| OS type for building Yocto: | --- | Type of Regression: | New (Never tested) |
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |
The codebase is origially for BBAY platform, there are some wrong and misleading prompt in setup page, I will remove them later. The functional fixes are in. Tim is working on improving the help text to make it more clear what each option does. This looks better in the 1522 test release from Tim, but keep open until we have something out to everyone. With the MNW2_IFWI_X64_D_2014_05_29_1410_SecEnabled.bin build the LPSS configuration page has a lot less misleading information, however, there is still some left. LPSS & SCC Devices Mode: "Enable/Disable LPSS & SCC Devices Mode" The options are ACPI and PCI Mode, so Enable/Disable doesn't make any sense here. This should read something about "Select Device Enumeration Mode" or something along those lines. We don't have an eMMC on the MinnowBoard-Max, so that entire block seems out of place to me. The label/help for DMA #1 and #2 doesn't indicate that this also enables/disables all of LPSS 1 and 2 respectively. A second statement about this being required in order to enable the other devices seems like it would be useful. Do we need to offer options for all the I2C buses under LPSS 2? It seems to me we only expose 2 of them? I don't understand what the "I2C Devics Configuration" is for. I presume Devics and Devic are typos, but why would we need a specific option for a Touch Device and another to enable/disable a SAR Sensor? What is a SAR sensor. Finally, I believe we discussed that by default (meaning after initial flash) we need to enable all the options under LPSS1 and 2 with the exception of flow control which should be disabled by default. Or was the intent here to set everything to GPIO so it can be setup safely as input? Per the Jun 12 discussion: LPSS I2C options: * Remove i2c buses that are not exposed * This leave 2 I2C buses * I2C (Low Speed Expansion): [Enable/Disable] * I2C (High Speed Expansion): [Enable/Disbale] Second, for all configurable lines (the ones exposed over the expansion buses), after flashing the firmware, the lines shall be setup as GPIO and direction initialized as input. This is to avoid any potential conflict with attached Lures which may be driving these lines. this bug should be identical to bug6488. I have modified some LPSS configuared as requirment (MNW2_IFWI_X64_R_2014_07_02_1150_SecEnabled.bin). Darren, Please test and verify then give me some suggestion. Tested the remaining two i2c options, and they work as expected with the calamari. I'd say this is resolved fixed |
The LPSS configuration lists devices and HIDs attached to the various options which are not meaningful and are misleading for the MinnowBoard MAX: LPSS I2C #1 -> I2C GPS | TBS (J6J1... LPSS I2C #2 -> LPE Audio | 10EC5640 LPSS I2C #3 -> MIPI -CSI CAM 3 | TBD(J1B2... LPSS I2C #4 -> Sony IMX175 CAM | INTCF1A OV2722 Camera | INT33FB Flash LM3554 | INTCF1C LPSS I2C #5 -> Sensor Hub | SM091D0 LPSS I2C #6 -> Touch Screen Dev | ATML1000 Touch FW Update | ATML2000 LPSS I2C #7 -> NFC card | MXP5441 Precision touchpad | MSFT002 We should not be documenting specific devices that are not attached to the device out of the box.