Bug 6618

Summary: Make the layer name searchable and show item page when search returns only one result
Product: [Yocto Project Subprojects] Layer Index Reporter: Belen Barros Pena <belen.barros.pena>
Component: Layer IndexAssignee: Jose Lamego <jose.a.lamego>
Status: RESOLVED FIXED QA Contact: David Lopez Barriba <davidx.lopez.barriba>
Severity: enhancement    
Priority: Medium CC: anibal.limon, benjamin.esquivel, bluelightning, brian.avery, elliot.smith, jose.perez.carranza, leonardo.sandoval.gonzalez, richard.purdie, sgw
Version: unspecified   
Target Milestone: 2.4 M1   
Hardware: All   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)
Bug Depends on: 7981    
Bug Blocks: 6670    

Description Belen Barros Pena 2014-08-07 17:21:21 UTC
To allow linking to recipes in the layer index from Toaster, we would like to be able to search for recipe_name+layer_name. For example:

http://layers.openembedded.org/layerindex/branch/master/recipes/?q=3g-router-image+meta-embeddedgeeks

Also, if the search returns only one result, to display the recipe details page, instead of the search results page with only one item.
Comment 1 Belen Barros Pena 2014-08-07 17:22:52 UTC
bug 6592 is the one needing this enhancement
Comment 2 Alex Franco 2015-10-29 01:53:05 UTC
Got a somewhat clunky working implementation, will refine and submit soon...
Comment 3 Alex Franco 2015-10-30 00:07:26 UTC
Sent "search enhancements" patch to list, waiting for review
Comment 4 Leonardo Sandoval Gonzalez 2016-06-14 17:32:34 UTC
Moving this to 2.2M2. I need to check if patches are already on proper repo.
Comment 5 Leonardo Sandoval Gonzalez 2016-07-25 20:54:17 UTC
Elliot,

According to the comment https://bugzilla.yoctoproject.org/show_bug.cgi?id=6618#c3 patches may be already on a repository so first task here is to see if those patches were either merged or not.
Comment 6 Elliot Smith 2016-08-01 09:23:49 UTC
Marking as NEEDINFO so Leonardo can check whether the patches are on a repository, as per comment 5.
Comment 7 Leonardo Sandoval Gonzalez 2016-08-04 17:07:33 UTC
Anibal will review current feature status.
Comment 8 Leonardo Sandoval Gonzalez 2016-08-04 18:08:22 UTC
Anibal will check if feature/commit is present.
Comment 9 Benjamin Esquivel 2016-11-09 18:17:04 UTC
Leo needs to talk to Paul and see if this bug will be done for 2.3
Comment 10 Leonardo Sandoval Gonzalez 2016-11-10 17:18:01 UTC
Series was sent but not merged:

https://lists.yoctoproject.org/pipermail/yocto/2015-October/027155.html

We need to review if these still apply and do proper testing.
Comment 11 Jose Lamego 2017-01-18 22:35:24 UTC
Changes were applied on top of current master and tested in a staging instance. Re-sent patches can be seen at:

https://lists.yoctoproject.org/pipermail/yocto/2017-January/033999.html
https://lists.yoctoproject.org/pipermail/yocto/2017-January/034000.html
Comment 12 Leonardo Sandoval Gonzalez 2017-01-25 17:18:55 UTC
Patches sent but probably not yet merged. Moving to M3.
Comment 13 Jose Lamego 2017-03-13 20:37:09 UTC
A reminder was sent to the ML. Moving to 2.4, waiting for merging.
Comment 14 Jose Lamego 2017-03-31 17:46:10 UTC
Change for single result redirect is implemented in:
c8c25fb641c500354cf36c3c59abb6f9fe96d223

pending a v2 for the recipe search requirement.
Comment 15 Jose Lamego 2017-04-03 19:37:17 UTC
It was suggested that a different approach should be taken for this request.

The new patch replicates the approach taken when supporting querying by "inherits" filed value: now the prefix "layer:" + the layer name can be used in queries by itself or combined with the recipe name or other supported options.
for example:
layer:openembedded-core

patch can be viewed at:
https://lists.yoctoproject.org/pipermail/yocto/2017-April/035451.html
Comment 16 Jose Lamego 2017-05-31 20:53:36 UTC
A new patch was sent to add the search by layer name feature. This new version includes descriptive messages when wrong formatting is used for the query string and when a non-valid layer name is searched:

https://lists.yoctoproject.org/pipermail/yocto/2017-May/036377.html
Comment 17 Jose Lamego 2017-06-15 13:20:58 UTC
A reminder was sent to the mailing list. Waiting to be integrated.
Comment 18 Jose Lamego 2017-06-15 15:01:35 UTC
Change to make layer name searchable merged in commit 	b958a991caa947fde2ccb073e3cb7924e162562d