Bug 6796

Summary:	eglibc-use-option-groups.patch -Wundef test failures
Product:	[Build System, Metadata & Runtime] OE-Core	Reporter:	Joseph Myers <joseph>
Component:	core	Assignee:	Juro Bystricky <juro.bystricky>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Medium	CC:	mark.hatle, meta.mr.watcher, meta.watcher
Version:	unspecified
Target Milestone:	1.7.2
Hardware:	x86
OS:	Multiple
Whiteboard:
OS type for building Yocto:	---	Type of Regression:	Regression (Used to work)
Verified:		Documentation change:	No (bug/feature does not impact docs)

Description Joseph Myers 2014-10-03 17:19:12 UTC

eglibc-use-option-groups.patch contains "#if __OPTION_EGLIBC_LOCALE_CODE" in libc-symbols.h but does not include gnu/option-groups.h there, so causing the nptl/tst-initializers* tests (which use -Werror) to fail to build since glibc uses -Wundef (it may well also cause other build warnings; glibc will probably soon move to making all -Wundef warnings into errors).

Comment 1 Juro Bystricky 2014-11-26 19:04:30 UTC

Posted a patch for a review to open-embedded-core.
The fix consists of not patching libc-symbols.h at all, and modifying the 
patch of the file posix/fnmatch.c instead in order to prevent multibyte character support if __OPTION_EGLIBC_LOCALE_CODE is not defined. I believe this was the sole purpose of patching libc-symbols.h. 
(fnmatch.c seems to be the only file affected by not patching libc-symbols.h)
Tested with both poky and poky-tiny image-core-minimal builds.

https://www.mail-archive.com/openembedded-core%40lists.openembedded.org/msg58903.html

Comment 2 Juro Bystricky 2015-03-10 22:21:31 UTC

Merged, commit
c453597d44a1a2301f4be7bf7a0853ea12eb448c