Bug 7041

Summary: Disable SSLv3 for webkit-gtk
Product: [Build System, Metadata & Runtime] OE-Core Reporter: Paul Eggleton <bluelightning>
Component: coreAssignee: Alexander Kanavin <alex.kanavin>
Status: VERIFIED OBSOLETE QA Contact: Cristina Agurida <cristina-danielax.agurida>
Severity: normal    
Priority: Medium CC: bogdanx.a.voiculescu, meta.mr.watcher, meta.watcher
Version: 1.7   
Target Milestone: 1.9 M1   
Hardware: All   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)

Description Paul Eggleton 2014-12-08 15:42:32 UTC
It looks as if webkit-gtk upstream has disabled SSLv3 to mitigate the POODLE vulnerability [1]. We should upgrade to the upstream release that does this or otherwise apply the fix.

[1] http://webkitgtk.org/2014/10/22/webkitgtk2.4.7-released.html
Comment 1 Ross Burton 2014-12-08 20:14:46 UTC
Upgrading webkit-gtk isn't simple, backporting that patch would be easier right now.
Comment 2 Ross Burton 2015-05-22 18:01:31 UTC
AlexK is looking at upgrading WebKit now in master which will fix this there.

https://github.com/WebKit/webkit/commit/95f950d42e2e9aa88a9c656ac51d636d9bfb0c14 is the fix upstream to *WebKit2* that disabled SSLv3 by default.  If Midori uses the WebKit 2 API then this patch should be backported to Fido, otherwise more investigation is required.
Comment 3 Ross Burton 2015-06-04 14:02:05 UTC
Re-assigning to Alex as he's been working on the webkit upgrade.

The upgrade will probably make this bug moot for master but we still need to identify what API Midori is using and whether the patch I found is suitable or not for Fido.
Comment 4 Alexander Kanavin 2015-06-05 12:13:33 UTC
Investigation:

Latest Midori upstream release (0.5.10) still defaults to webkit1 and gtk2. It supports gtk3 and webkit2, but as those are not default I presume their support is not mature. Will re-assess when 0.6.0 is out.

Therefore, the webkit update will be to 2.4.9, which is the last version that still carries both webkit1 and webkit2 (later versions drop webkit1). 

SSLv3 was never disabled in webkit1, because "it's not possible to do it reliably" (talk about engineering quality!!!), and it's up to the applications to do the disabling.

Latest Midori does not do such disabling (judged from reading the source code; didn't yet verify it with check-ssl3 websites).

Outcome:

we have to add the ssl3 disabling patch ourselves; fortunately Red Hat has done it for us:
https://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20150112/1489390.html
Comment 5 Alexander Kanavin 2015-06-12 12:24:54 UTC
Actually, the above may be moot now. I'm now testing epiphany; if it works ok, let's replace midori with that. Epiphany is already using Webkit2 (where ssl3 is disabled properly), and GTK3.
Comment 6 Alexander Kanavin 2015-07-07 10:17:54 UTC
The issue is moot, as webkit will be upgraded to latest upstream, the patchset has been completed and submitted for review.
Comment 7 Cristina Agurida 2015-09-14 15:12:12 UTC
As per last comments set it as verified obsolete.