Bug 7051

Summary:	the all layers page shows two core layers for different layer sources when filtering, and wrong search results
Product:	[Build System, Metadata & Runtime] Toaster	Reporter:	Belen Barros Pena <belen.barros.pena>
Component:	toaster	Assignee:	Alexandru Damian <alexandru.damian>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Medium	CC:	alexandru.damian, belen.barros.pena, cristiana.voicu
Version:	1.7
Target Milestone:	1.8
Hardware:	x86
OS:	Multiple
Whiteboard:
OS type for building Yocto:	---	Type of Regression:	---
Verified:		Documentation change:	No (bug/feature does not impact docs)

Description Belen Barros Pena 2014-12-09 12:42:53 UTC

Found in poky/master:b813bdebb36501500e86fea5f7e15b4b15ea0902 

Steps to reproduce:

* Create a project with release "yocto project master"
* Build something provided by the core layers (for example, core-image-minimal)
* Once the build is complete, visit the all layers page
* Click the filter button in the 'Layer source' column: a 'Local Yocto Project' layer source is showing, with 3 layers in it. Select this layer source and click apply

Outcome: openembedded-core, meta-yocto and meta-yocto-bsp will show. Those layers should never show for a project with release "Yocto Project master". 

Expected outcome: The version of the layers shown should be the OpenEmbedded | master one, not the Local Yocto Project | master one. There should only be one instance of the core layers in any project, and it should match the selected project release.

* Clear the filter by hovering over the 'Layer source' filter button and clicking on the 'Show all layers' button inside the tooltip

* Search for "openembedded-core"

Outcome: the page heading says '3 layers found', but only 2 layers are listed on the table (openenbedded-core for the Local Yocto Project and meta-kde4).

Expected outcome: the page heading should say '1 layer found' and the table should show the openembedded-core layer for the OpenEmbedded layer source with branch 'master'.

Comment 1 Alexandru Damian 2015-01-20 16:20:27 UTC

The layers shown in the "All layers" page are the layers used to actually build the project. 

The "Local" layers appear here instead of of the layer index ones because the toasterconf.json sets higher precedence to Local layer source compared to OpenEmbedded layer source.

The Project release specifies the branch and not the layer source of the layers. Indeed, the Local layers are checked out on the project release branch - master.

I think this behavior is correct - if not, we need to revisit the entire layer checkout strategy.

--

The "meta-kde4" entry for the search is valid because the search matches the Git URL field, which is a valid target for search. It happens that 	meta-kde4 GIT is  https://gitorious.org/openembedded-core-layers/meta-kde4.git 

--

The found number of layers in the search results is indeed wrong. Working on this bug.

Comment 2 Alexandru Damian 2015-01-20 16:39:54 UTC

Pushed for review on 

poky-contrib:adamian/20150119-fixes

Comment 3 Alexandru Damian 2015-01-23 17:44:41 UTC

merged into master