| Summary: | Make the add layer notification for layers with dependencies consistent across Toaster pages | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] Toaster | Reporter: | Belen Barros Pena <belen.barros.pena> | ||||||
| Component: | toaster | Assignee: | Michael Wood <michael.g.wood> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | Alexandru Roman <alexandru.costinx.roman> | ||||||
| Severity: | normal | ||||||||
| Priority: | Low | CC: | alexandru.costinx.roman, alexandru.damian, belen.barros.pena, bluelightning, cristiana.voicu, jessica.zhang | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | 1.9 | ||||||||
| Hardware: | x86 | ||||||||
| OS: | Multiple | ||||||||
| Whiteboard: | front-end | ||||||||
| OS type for building Yocto: | --- | Type of Regression: | --- | ||||||
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |||||||
| Bug Depends on: | 7329 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
Created attachment 2376 [details]
added-layer-notification-all-layers.png
I think once the all machines page is merged we'll have got them all (In reply to comment #2) > I think once the all machines page is merged we'll have got them all No, not yet. We need to change the add layer notification in the all layers page and in the project page, which don't differentiate between the layer you added and its dependencies (like the other pages very nicely do). merged in master This is still not fixed. The add layer notifications we display in the project page and the all layers page are still different from the ones we show in the layer details page. To see what I mean, create a project. Then go to the layer details page for the meta-tizen layer and add meta-tizen to your project from there. Then go back to the project page and remove the 5 layers added when you added the meta-tizen layer (meta-intel, meta-efl, meta-multimedia, meta-ruby and meta-tizen). Then add meta-tizen again from the project page. The notification you see is different from the one you got in the meta-tizen layer details page. We should have consistent messaging across Toaster. Believe this is now fixed with the new project page implementation Verify on master: c75cefe8a382a63f625123c156137782db118f64 |
Created attachment 2375 [details] added-layer-notification-layer-details.png We have almost managed the miracle of making notifications consistent across Toaster, but not quite yet. One of the things left to fix is the notification you see when adding layers that bring in other layers as dependencies. You can add layers from the following Toaster pages: * The project page * The all layers page * The all targets page * The all machines page * The layer details page When you add more than one layer at the same time due to layer dependencies, the design asked for a notification like this: You have added <no_of_layers> layers to <project_name>: <added_layer> and its dependencies <list of layer dependencies> This is what the layer details page does, as you can see in the attached image added-layer-notification-layer-details.png The rest of the pages, however, do not make the distinction between added layer and its dependencies. The notifications, therefore, are like the one shown in the attached added-layer-notification-all-layers.png Notifications should be exactly the same across pages, so we need the to bring the notifications shown in the project, all layers, all targets and all machines pages in line to the ones shown in the layer details pages. This means adding the distinction between the added layer and its dependencies.