Bug 7376

Alternatively, should those tests be migrated over to meta/lib/oeqa/selftest/ ?

 it doesn't run tests in meta/lib/oe ... with or without subdirs. It does however running those from lib/oeqa/selftest. There were quite some mods lately for oe-selftest, so i guess moving them to oeqa/selftest would be a good approach.

Migrating the tests is probably the right thing to do.

Reassigning to Alex, can someone in QA review the tests and scope out how many of those could be moved to selftest?

FYI, as of just recently in master oe-selftest now sets up the python path so that both bb and oe modules can be imported, so we can now do more unit test type tests in oe-selftest (which appears to be what meta/lib/oe/tests was meant to be).

(In reply to comment #4)
> FYI, as of just recently in master oe-selftest now sets up the python path
> so that both bb and oe modules can be imported, so we can now do more unit
> test type tests in oe-selftest (which appears to be what meta/lib/oe/tests
> was meant to be).

Seems interesting we'll have a look

Hi, 

In a way, this is related to 7865. I guess we should modify in the first place scriptpath.add_oe_lib_path() to add also other layers present in BBPATH to the oe-selftest python's sys path.
Also for this to take effect oe-selftest's get_tests() method should consider dir structure different than oeqa/selftest

I don't think we can simply make scriptpath.add_oe_lib_path() look in BBPATH because it would then require us to query the value of BBPATH (which is not a problem in oe-selftest context, but would be in others). I wouldn't be opposed to adding a parameter that let you pass in the BBPATH though, or a separate function which did the query using tinfoil (see what scripts/devtool does to get it).

I'll have a look on tests from lib/oe to move them in oeqa/selftest

is this still happening Mariano?

I'm working on this bug assigning it back to me.

Selftest will look for test in <layer>/lib/oeqa/selftest for every layer in BBLAYERS. In this case the tests are in meta/lib/oe/tests, so selftest won't find them

Patch already sent 

http://lists.openembedded.org/pipermail/openembedded-core/2016-November/128395.html

Checking these tests all of them check for functions/classes located in meta/lib/oe; I have some comments regarding for these tests.

1. The tests don't check the functionality of the build system. Is the right place to put them under selftest?
2. If you want to run them in the autobuilder, it is possible to hardcode the path in oe-selftest.

I appreciate they are not the same kinds of tests we normally do within oe-selftest, however they are testing library functions used by the build system.

The reason I am suggesting moving them to oe-selftest is because we really don't need yet another place where we define and run tests.

(In reply to comment #14)
> I appreciate they are not the same kinds of tests we normally do within
> oe-selftest, however they are testing library functions used by the build
> system.
> 
> The reason I am suggesting moving them to oe-selftest is because we really
> don't need yet another place where we define and run tests.
I think you're right, these tests should be alright in seltest as they don't add more than a couple of minutes to the execution. I'll reply something at the review.

Patch V2 sent to mailing list 

http://lists.openembedded.org/pipermail/openembedded-core/2016-November/128815.html

Merged on master: 

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=d535aba974d47802c80ea1f9c678c0e8351523bb

Created attachment 3760 [details]
core-image-sato-sdk_x86-64MMax64.log

(In reply to comment #18)
> Created attachment 3760 [details]
> core-image-sato-sdk_x86-64MMax64.log

Verified, tested in commit:381897c64069ea43d595380a3ae913bcc79cf7e1