Bug 7461

Summary: Filters not working as designed
Product: [Build System, Metadata & Runtime] Toaster Reporter: Belen Barros Pena <belen.barros.pena>
Component: toasterAssignee: David Reyna <david.reyna>
Status: VERIFIED FIXED QA Contact: Mihail Stanciu <stanciux.mihail>
Severity: normal    
Priority: Medium+ CC: alexandru.c.georgescu, alexandru.damian, belen.barros.pena, bluelightning, cristiana.voicu, david.reyna, jessica.zhang
Version: unspecified   
Target Milestone: 1.8 M4   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)

Description Belen Barros Pena 2015-03-16 13:46:46 UTC 
The relationship between search and filters are like this:

The scope of the filters is the content currently on the table.

The scope of the search is always the full content of the database.

So:

- if I run a search query, any filter applied afterwards will filter the content returned by the search query.

- if I run a search query while a filter is applied, the filter is overridden by the results of the search query (i.e. we display the results of the search query and clear the filter applied beforehand).

Currently, the filter counters are not reflecting the above behaviour. 

If you apply a filter (for example, if you select the "Successful builds" option in the "Outcome" filters of the "All builds" page), the "all" option counter shows the number of records returned by the filter, instead of the total number of records in the database.

If you search, then apply a filter, the "all" option shows the number of records returned by the search (which is the correct behaviour), but the other options show the total number of records in the database (this is not the correct behaviour), instead of showing only the numbers applicable to the search results. 

I also appreciate how the heading of the filter is trying to tell you what the filter will be applied to, but the resulting string is a big to complicated. Something like "Filter search results by <column_heading>" might be easier to process.
Comment 1 David Reyna 2015-03-18 00:12:35 UTC 
I also encountered this issue.

I observed that 'total_count' always uses “queryset_with_search.count()”, but that is wrong since that query also include any filtering. The observed error is that the “all” count in the filter popup will show the current limited filtered/searched count and not the full count, and that just looks wrong.

I fixed it in the two all builds tables (via 6040, under review), but I have not touched the other view classes yet. Here is my fix:
                    

-               'total_count' : queryset_with_search.count(),
+               'total_count' : queryset_all.count(),
Comment 2 Belen Barros Pena 2015-03-19 12:10:21 UTC 
I've had a look at the filters behaviour and at the counter information. The funniest thing is that the filters are behaving as per the design specs. But the counters show the wrong information, and that totally throws you off. 

The easy way of solving the problem is removing the counters. Removing the counters from the filters also removes our mechanism to stop users from selecting filter options that return zero entries. We should have a state in place for that case (built as part of the empty states specification), but we need to make sure we test this case.
Comment 3 David Reyna 2015-03-25 16:29:25 UTC 
Belen's proposal was adopted.
Comment 4 Mihail Stanciu 2015-03-31 12:39:48 UTC 
Verified on master: 8b3d3e7c957ad06c390886487f69aeb8e145da6a