Bug 7627

Summary: Kernel checkout requires master branch
Product: [Build System, Metadata & Runtime] OE-Core Reporter: Steve Pomeroy <steve>
Component: kernelAssignee: Bruce Ashfield <bruce.ashfield>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Undecided CC: bruce.ashfield, tom.zanussi
Version: unspecified   
Target Milestone: ---   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)
Attachments:
Description Flags
aforementioned patch none

Description Steve Pomeroy 2015-04-17 22:24:28 UTC 
Created attachment 2480 [details]
aforementioned patch

http://cgit.openembedded.org/openembedded-core/commit/?id=2ffa3f8be6996877cd552ff22260de35c19c413d introduced a bug where a branch named "master" is required for a kernel checkout to succeed (while usually true, this isn't necessarily the case in all repositories). The logic seems to have been inverted. 

Attached is a patch that should address the situation.
Comment 1 Bruce Ashfield 2015-04-18 01:15:01 UTC 
This is already fixed in master (as mentioned on the mailing list). The
logic was inverted, but we'll now only fall back to master if the machine
branch doesn't exist.
Comment 2 Bruce Ashfield 2015-04-18 01:17:06 UTC 
In particular, I'm not all that concerned about working with
repositories with no master. If we handled every single repository
variant, the complexity becomes to much.

Having a well known (and sane) fallback of master is appropriate in
nearly every case.
Comment 3 Steve Pomeroy 2015-04-18 14:42:20 UTC 
Ah. I didn't see af691920c0e289fd0eb13d94cad03c799375af21 as I was only looking on the dizzy branch. Is this a change that can make it to 1.7.2?

Just leaving it be the "master" branch sounds good to me.
Comment 4 Bruce Ashfield 2015-04-19 03:59:53 UTC 
I'll post the patch for a backport to stable.

Thanks for working through this, and sorry for issues it may
be causing for your builds!

(In reply to comment #3)
> Ah. I didn't see af691920c0e289fd0eb13d94cad03c799375af21 as I was only
> looking on the dizzy branch. Is this a change that can make it to 1.7.2?
> 
> Just leaving it be the "master" branch sounds good to me.
Comment 5 Bruce Ashfield 2015-04-24 20:03:36 UTC 
send the patch to the list.
Comment 6 Bruce Ashfield 2015-04-28 19:12:38 UTC 
Patch posted for backport.