Bug 77

Summary: ROOTFS_POSTPROCESS_COMMAND bug
Product: [Build System, Metadata & Runtime] Meta-yocto Reporter: Readon Shaw <xydarcher>
Component: meta-yoctoAssignee: Richard Purdie <richard.purdie>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: medium CC: poky.bs.watcher, poky.watcher
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: x86   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: ---

Description Readon Shaw 2009-11-10 09:23:28 UTC
when i add ROOTFS_POSTPROCESS_COMMAND += "remove_packaging_data_files" in the image bb file.
it generate "rootfs_update_timestamp remove_packaging_data_files" in run.do_rootfs file,
where "rootfs_update_timestamp" and "remove_packaging_data_files" functions would not be executed.

i tried to fix that.
here is the patch.

diff --git a/meta/classes/rootfs_ipk.bbclass b/meta/classes/rootfs_ipk.bbclass
index 50df68c..caf6abd 100644
--- a/meta/classes/rootfs_ipk.bbclass
+++ b/meta/classes/rootfs_ipk.bbclass
@@ -53,7 +53,10 @@ fakeroot rootfs_ipk_do_rootfs () {
        install -d ${IMAGE_ROOTFS}/${sysconfdir}
        echo ${BUILDNAME} > ${IMAGE_ROOTFS}/${sysconfdir}/version
 
-       ${ROOTFS_POSTPROCESS_COMMAND}
+       for i in ${ROOTFS_POSTPROCESS_COMMAND}
+       do
+               ${i}
+       done
        
        log_check rootfs        
 }
Comment 1 Richard Purdie 2009-11-10 09:42:11 UTC
This variable is intended to be used as:

 ROOTFS_POSTPROCESS_COMMAND += "remove_packaging_data_files;"

and it should then work without your patch. If there is a ";" missing somewhere else we need to fix that too.
Comment 2 Readon Shaw 2009-11-10 10:22:57 UTC
(In reply to comment #1)
> This variable is intended to be used as:
> 
>  ROOTFS_POSTPROCESS_COMMAND += "remove_packaging_data_files;"
> 
> and it should then work without your patch. If there is a ";" missing somewhere
> else we need to fix that too.
> 

I follow the instruction you said.
but no magic appears.
it shows "rootfs_update_timestamp remove_packaging_data_files;" in run.do_rootfs file.
but in log.do_rootfs file,it has no effects.
Comment 3 Readon Shaw 2009-11-10 16:34:41 UTC
(In reply to comment #1)
> This variable is intended to be used as:
> 
>  ROOTFS_POSTPROCESS_COMMAND += "remove_packaging_data_files;"
> 
> and it should then work without your patch. If there is a ";" missing somewhere
> else we need to fix that too.
> 

another patch is needed.

diff --git a/meta/classes/poky-image.bbclass b/meta/classes/poky-image.bbclass
index 82f11b7..071da0a 100644
--- a/meta/classes/poky-image.bbclass
+++ b/meta/classes/poky-image.bbclass
@@ -81,4 +81,4 @@ SATO_IMAGE_FEATURES = "${X11_IMAGE_FEATURES} apps-x11-sato apps-x11-games apps-x
 inherit image
 
 # Create /etc/timestamp during image construction to give a reasonably sane default time setting
-ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp"
+ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp;"
Comment 4 Richard Purdie 2009-11-12 16:53:28 UTC
This fix has already been made in the master branch. Which branch are you using, pinky?
Comment 5 Richard Purdie 2009-11-12 18:36:45 UTC
I pushed this fix in the pinky branch and it was included with the release.
Comment 6 Readon Shaw 2009-11-13 01:26:49 UTC
(In reply to comment #5)
> I pushed this fix in the pinky branch and it was included with the release.
> 

ok, i am using release 3.1.1