Bug 7828

Summary: Impossible to add a new image type in Toaster
Product: [Build System, Metadata & Runtime] Toaster Reporter: Belen Barros Pena <belen.barros.pena>
Component: toasterAssignee: Sujith H <sujith.h>
Status: RESOLVED FIXED QA Contact: Libertad <libertad.gonzalez.de.la.cruz>
Severity: normal    
Priority: Medium+ CC: alexandru.damian, belen.barros.pena, bluelightning, cristiana.voicu, david.reyna, jessica.zhang, jose.perez.carranza, joshuagloe, julien.gueytat
Version: 1.8   
Target Milestone: 2.2 M2   
Hardware: x86   
OS: Multiple   
Whiteboard: GUI design available
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)
Attachments:
Description Flags
Design - Adding image types
none
Design - Adding image types
none
Design - Adding image types none

Description Belen Barros Pena 2015-05-29 16:21:03 UTC 
Someone in the mailing list trying to build meta-raspberrypi reported the fact that he could not add a value to the list provided by Toaster for IMAGE_FSTYPES. 

The machine configuration of meta-raspberrypi contains this line

IMAGE_FSTYPES ?= "tar.bz2 ext3 rpi-sdimg"

Because of the way the variable is set, the value is overriden by the one set by Toaster, so no rpi-sdimg image was being created. This was causing trouble because you cannot add 'rpi-sdimg' to the value of IMAGE_FSTYPES in Toaster. 

So we either:

* Generate the list of values provided by Toaster for IMAGE_FSTYPES in such a way that reflects the options provided by the layers added to the project (which I am not even sure is possible)

* We provide a free text field in Toaster so that you can add custom values to the IMAGE_FSTYPES variable.

This also brings up the question: where does the list of values provided by Toaster for IMAGE_FSTYPES come from? How is it being generated?
Comment 1 Michael Wood 2015-08-13 13:06:07 UTC 
It sounds like in this case we need to provide a free form text field. 

The current list just comes from  http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/classes/image_types.bbclass copied in to lib/toaster/toastergui/views.py:2552 (it's actually slightly out of date)
Comment 2 Belen Barros Pena 2015-08-13 14:25:49 UTC 
mmm, I don't think that list should be hardcoded in views.py. Shouldn't it come from toasterconf.json, like the MACHINE or the DISTRO?

Also, this needs designing.
Comment 3 Belen Barros Pena 2015-09-11 15:31:19 UTC 
Created attachment 2728 [details]
Design - Adding image types
Comment 4 Belen Barros Pena 2015-09-11 15:32:09 UTC 
This was set to needinfo, but I think I've answered the question (I think)
Comment 5 Belen Barros Pena 2015-11-19 16:04:27 UTC 
Created attachment 2857 [details]
Design - Adding image types
Comment 6 Belen Barros Pena 2015-12-15 12:27:07 UTC 
Created attachment 2901 [details]
Design - Adding image types

So, version 3 of this. Hopefully this is the good one.
Comment 7 Belen Barros Pena 2015-12-15 13:07:12 UTC 
The design that was implemented had some problems. New design available, and I'm afraid some changes required, so reopening. 

Apologies to the bug assignee for the mess.
Comment 8 Michael Wood 2016-02-05 19:18:13 UTC 
We tried a number of different designs and implementations so this work was started again hence milestone bump
Comment 9 Sujith H 2016-07-13 09:41:14 UTC 
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=c81d03e8a30d9ac62e7162794b41f7e0c21e0a61 is the commit which is merged upstream for this task. Hence marking this task as Resolved-Fixed.