Bug 7969

Summary: Toaster shows recipes without names to users
Product: [Build System, Metadata & Runtime] Toaster Reporter: Belen Barros Pena <belen.barros.pena>
Component: toasterAssignee: Ed Bartosh <eduard.bartosh>
Status: VERIFIED FIXED QA Contact: Alexandru Roman <alexandru.costinx.roman>
Severity: normal    
Priority: Medium CC: alexandru.costinx.roman, alexandru.damian, belen.barros.pena, bogdanx.a.voiculescu, cristiana.voicu, eduard.bartosh, elliot.smith, jessica.zhang
Version: 1.8   
Target Milestone: 2.0   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)
Attachments:
Description Flags
recipe without name none

Description Belen Barros Pena 2015-07-08 14:51:16 UTC
Created attachment 2579 [details]
recipe without name

It is possible that the information Toaster imports from the layer index is "corrupted" in some way, with interesting side effects. The one I've recently seen (see screenshot attached) is recipes without a name. Such recipes display an 'add layer' button and, once you've added the layer to the project, a 'build' button, like any other recipe, but when you click 'build' the build does not start. 

Such recipes should be filtered out from the data Toaster shows to users, so that no recipe without a name + release is displayed.
Comment 1 Ed Bartosh 2015-10-01 14:07:41 UTC
I can't reproduce it in my setup. Should I use another release or branch to see those layers?
Comment 2 Belen Barros Pena 2015-10-01 16:15:05 UTC
Toaster seems to panic and create recipe entries without a name when the following happens:

* when a layer in the layer index provides more than one recipe with the same version, like here

http://layers.openembedded.org/layerindex/branch/master/layer/e100-bsp/
http://layers.openembedded.org/layerindex/branch/master/layer/meta-ivi/

According to Brian, this is our bug and we should just overwrite and take the last entry.

* when a layer has invalid recipes, like here

http://layers.openembedded.org/layerindex/branch/master/layer/meta-gumstix-community/
Comment 3 Ed Bartosh 2015-10-01 17:55:29 UTC
I've sent fix for review: https://lists.yoctoproject.org/pipermail/toaster/2015-October/002959.html
Comment 4 Ed Bartosh 2015-10-13 08:16:30 UTC
The fix accepted upstream: http://cgit.openembedded.org/bitbake/commit/?id=f7c1bd49e2e28d12c6604f5ae54bc96e1e7b6946
Comment 5 Alexandru Roman 2015-11-03 14:36:12 UTC
Verified