Bug 8131

Summary: All builds page "Errors"/"Warnings" filters doesn't work
Product: [Build System, Metadata & Runtime] Toaster Reporter: Cristina Agurida <cristina-danielax.agurida>
Component: toasterAssignee: Michael Wood <michael.g.wood>
Status: RESOLVED OBSOLETE QA Contact: Libertad <libertad.gonzalez.de.la.cruz>
Severity: normal    
Priority: Medium CC: alexandru.c.georgescu, alexandru.damian, belen.barros.pena, cristiana.voicu, elliot.smith, jessica.zhang, stanciux.mihail
Version: 1.9   
Target Milestone: 2.2   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: Regression (Used to work)
Verified: Documentation change: No (bug/feature does not impact docs)
Bug Depends on: 8738    
Bug Blocks:    
Attachments:
Description Flags
toaster.sqlite
none
screenshot
none
traceback none

Description Cristina Agurida 2015-08-10 12:17:33 UTC
Created attachment 2643 [details]
toaster.sqlite

STATUS: FAILED
BUILD: 1.9_M2.rc2: c75cefe8a382a63f625123c156137782db118f64
ENVIRONMENT: Ubuntu 15.04 x86_64

STEPS TO REPRODUCE: 

1. Start Toaster in managed mode.
2. Create two builds.
3. Try to filter by errors/warnings

Expected outcome:

Filters should work.

Actual outcome:

Page fails with error.
See screenshot and attachments for error.
Comment 1 Cristina Agurida 2015-08-10 12:18:27 UTC
Created attachment 2644 [details]
screenshot
Comment 2 Cristina Agurida 2015-08-10 12:19:11 UTC
Created attachment 2645 [details]
traceback
Comment 3 Belen Barros Pena 2015-08-19 15:30:54 UTC
8011 covers this

*** This bug has been marked as a duplicate of bug 8011 ***
Comment 4 Belen Barros Pena 2015-08-19 15:34:58 UTC
Sorry, my bad: this is a different issue. Assigning to Michael
Comment 5 Michael Wood 2015-09-28 17:13:19 UTC
There are no simple fixes for this that I can see. The field which it used to filter on was removed in this commit:

commit 70c4eb8d3acaad267ee943ebfba793f9cc1c5ee6
Author: Alexandru DAMIAN <alexandru.damian@intel.com>
Date:   Wed Jun 17 17:30:34 2015 +0100

    bitbake: toaster: refactor build model
   
    We remove the "timespent", "errors_no" and "warnings_no" fields
    in favor of computing the needed values at runtime. This prevents
    inconsistencies in the UI.
   
    Also removeing all references to BuildRequests from the interface -
    all build details now display in the build dashboard.
   
    Minor fixes related to data logging.
   
    (Bitbake rev: 44f37394ed3e4ca02f940be172fe4395b0ee0f7d)
   
    Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
    Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

We will need a new mechanism to do the filtering, we will also be porting this table to ToasterTables so this can be fixed at that point.
Comment 6 Michael Wood 2015-09-28 17:42:03 UTC
*** Bug 8011 has been marked as a duplicate of this bug. ***
Comment 7 Mihail Stanciu 2015-10-14 14:57:46 UTC
"TIME" filter still exists and is failing in 2.0: eac61f37e36099f74485dab398b57f3812826d17 . "Errors" and "Warnings" are gone, as per the patch Michael quoted above.
Comment 8 Belen Barros Pena 2015-10-14 16:26:02 UTC
I think we might be talking about both filters and sorting, and hence the confusion. In any case, both are gone from 

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=9daf6ef908eb7907f30c18a34dded1929ef66671
Comment 9 Elliot Smith 2015-12-18 09:18:42 UTC
We no longer have filters or sorting on these columns. Should it be put in again?
Comment 10 Belen Barros Pena 2015-12-18 09:47:38 UTC
(In reply to comment #9)
> We no longer have filters or sorting on these columns. Should it be put in
> again?

Yes :) I took them away because better not have them than have them broken, but I was hoping that moving those tables to ToasterTables would fix the issue and we would be able to have them back.
Comment 11 Elliot Smith 2015-12-18 10:01:07 UTC
OK, it should be reasonably easy to add those filters back in once my patch set for bug 8738 has been merged.
Comment 12 Alexandru Georgescu 2016-02-04 09:58:24 UTC
seems that the issue still exists in YP 2.1_M2.rc1
master/3d2c0f5902cacf9d8544bf263b51ef0dd1a7218c
Comment 13 Michael Wood 2016-06-06 10:34:41 UTC
Marking this as obsolete as the original issue with the exception/traceback shown is no longer reproduce-able. Ordering by no. Warnings or Errors is working as expected.