Bug 8190

Summary: The 'set in file' filters in the BitBake variables table seem to return the wrong information
Product: [Build System, Metadata & Runtime] Toaster Reporter: Belen Barros Pena <belen.barros.pena>
Component: toasterAssignee: David Reyna <david.reyna>
Status: ACCEPTED --- QA Contact:
Severity: normal    
Priority: Low CC: belen.barros.pena, david.reyna, jessica.zhang
Version: 1.8   
Target Milestone: 5.99   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)
Attachments:
Description Flags
image of feature working none

Description Belen Barros Pena 2015-08-20 16:49:29 UTC
For example, selecting the 'local configuration variables' option returns no variables. This option is supposed to list the variables set in local.conf, so it should definitely return some variables.
Comment 1 Belen Barros Pena 2015-08-20 16:57:17 UTC
Also, when you select a filter, the file displayed in the 'set in file' column does not match the selected filter.

For example, go to the BitBake variables table for any build, click on the filter button in the 'set in file' column, select the 'layer configuration variables' option. 

In the results listed, check the BBPATH variable. The file shown in the 'set in file' column is not layer.conf but data_smart.py
Comment 2 Belen Barros Pena 2016-04-25 14:37:02 UTC
I am not sure if Brian Avery will be able to do much Toaster work, so setting this one to the default assignee for the time being. Brian: feel free to take it back if you really want it!
Comment 3 David Reyna 2016-08-26 22:51:31 UTC
I tried this on Aug 26 2016, and I cannot replicate either the first nor the second issue.

I do see paths when the filter is 'local configuration variables'. 

I do see the 'set in file' column matching the selected filter.

This was probably fixed by other patches.
Comment 4 David Reyna 2016-08-27 01:46:52 UTC
Created attachment 3393 [details]
image of feature working

Attached is an image showing that the feature is currently working.
Comment 5 Belen Barros Pena 2016-08-30 16:43:55 UTC
(In reply to comment #3)
> I tried this on Aug 26 2016, and I cannot replicate either the first nor the
> second issue.
> 
> I do see paths when the filter is 'local configuration variables'. 

Same here: I can no longer replicate this problem.

> 
> I do see the 'set in file' column matching the selected filter.

But I can still see this one. If in the 'set in file' filter you select the "Layer configuration variables" option (which is supposed to show you the variables set in layer.conf files), I can see that BBFILES is listed, and the file shown is 

/home/belen/poky/_toaster_clones/_git___git.yoctoproject.org_poky_master/bitbake/lib/bb/cooker.py

If you click the variable name, you see that BBFILES is indeed set also in layer.conf, but instead of showing that file, which is the relevant one, the table seems to be showing the last file on the list (in this case, cooker.py). The same happens with COREBASE, for example.


> 
> This was probably fixed by other patches.
Comment 6 David Reyna 2017-01-10 20:38:45 UTC
I am resetting this to accepted and two days estimate for the remaining issue. I am also moving this to M3 since it is non-blocking.
Comment 7 David Reyna 2017-09-13 01:28:30 UTC
I can replicate Belen's observation that for example "BBFILES" shows "/cooker.py" in the "Set In File" column for layer variables.

However, the "Set In File" help states that the value is supposed to be the last file that touches the variable, so by that the displayed value is correct, albeit counter intuitive.

In contrast, the local variable filter shows the first file that touches the value (which would be "local.conf"), which feels right even though it is far from the last file to touch the value.

I am moving this to the next release since (a) it is not blocking and (b) there is really no 'right' answer. The task is the decide the 'right' answer (which is probably the first file that defines and touches the value) and then make all filters match it.
Comment 8 Randy MacLeod 2023-10-24 14:24:42 UTC
Bulk move from 4.99 or 0.00 to 5.99