Bug 8290

Summary: oe-selftest unresolved dependency in buildoptions test
Product: [QA/Testing] Build Testing Reporter: Benjamin Esquivel <benjamin.esquivel>
Component: generalAssignee: Scott Rifenbark <srifenbark>
Status: VERIFIED FIXED QA Contact: Bogdan Alexandru Voiculescu <bogdanx.a.voiculescu>
Severity: normal    
Priority: Low CC: bluelightning, bogdanx.a.voiculescu, srifenbark
Version: 1.9   
Target Milestone: 2.0   
Hardware: x86   
OS: Multiple   
Whiteboard: 23 Sept 2015 - RESOLVED/FIXED
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: Done (doc changes complete)

Description Benjamin Esquivel 2015-09-11 19:48:18 UTC
the buildoptions test imports pexpect and not all systems contain it.

You can see it here:

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/tree/meta/lib/oeqa/selftest/buildoptions.py?id=e47e1c499b302800cf39f08442f6b452483abc62
Comment 1 Paul Eggleton 2015-09-17 15:02:40 UTC
I think this is really a documentation issue. We should be noting this additional dependency in the "Required Packages for the Host Development System" reference manual section, but we need to create an additional category for "Packages required for oe-selftest" under each distro; then of course we need the actual pexpect package name for each distro. For Fedora it's python-pexpect, for CentOS I think it's pexpect (though that's for CentOS 6, I haven't checked 7).
Comment 2 Scott Rifenbark 2015-09-17 16:00:28 UTC
Ok - We can add a category called "OE Self-Test Extras" and in the verbiage I can explain that the packages are necessary to run the OE self-test stuff.  I will need the exact package names for each Distro:

 * Fedora - python-pexpect
 * Ubuntu and Debian - ???
 * CentOS - pexpect (others by Distro release????)
 * OpenSUSE - ???
Comment 3 Benjamin Esquivel 2015-09-17 16:34:28 UTC
I confirmed that:

OpenSuse = python-pexpect
Fedora = python-pexpect

And it looks like Ubuntu would also be python-pexpect as well. Needs confirmation.
Comment 4 Benjamin Esquivel 2015-09-18 16:15:44 UTC
I think this patch helps to be clear about what's going wrong when trying to import pexpect and is not there:

https://bugzilla.yoctoproject.org/buglist.cgi?cmdtype=runnamed&namedcmd=YP-1.9-or-2.0-GDC-Open&list_id=467314

Take into account that before this patch it would just say that buildoptions can't be imported instead of referring to the actual module it is missing.
Comment 5 Benjamin Esquivel 2015-09-18 17:00:53 UTC
There is this other dependency that breaks the testing that should get the same treatment: GitPython.

Can we work it out as part of this same bug? should I file another?

Just as an FYI, GitPython OS install table is:

* Fedora: GitPython
* OpenSuse: python-GitPython
* Ubuntu: python-git
Comment 6 Scott Rifenbark 2015-09-22 14:09:38 UTC
Probably handle it here as part of the same bug.  

So what are the final package dependencies we need to cover it all?

Ubuntu and Debian: python-pexpect, python-git
Fedora: python-pexpect, GitPython
CentOS: pexpect
OpenSUSE: python-pexpect, python-GitPython

Does this do it?  Is there another one for CentOS needed?

Thanks,
Scott
Comment 7 Benjamin Esquivel 2015-09-22 16:43:56 UTC
pexpect turns out to be an unused reference and it has been marked for removal so this means the bug might cover GitPython only.

The list would be:

Ubuntu and Debian: python-git
Fedora/CentOS: GitPython
OpenSUSE: python-GitPython

CentOS reference is added now there
Comment 8 Scott Rifenbark 2015-09-23 15:38:25 UTC
Hi, 

I have added new sections in the ref-manual to cover the required packages when running oe-selftest.  You can see the changes at http://www.yoctoproject.org/docs/1.9/ref-manual/ref-manual.html#required-packages-for-the-host-development-system.  Please look them over and approve or correct.

Thanks,
Scott
Comment 9 Benjamin Esquivel 2015-09-23 15:49:54 UTC
It looks good to me.
Comment 10 Scott Rifenbark 2015-09-23 17:36:44 UTC
Great - I am setting to RESOLVED/FIXED and turning the doc flag to "Done."

Thanks
Comment 11 Bogdan Alexandru Voiculescu 2015-10-28 13:49:32 UTC
Verified: is ok with me.