Bug 8546

Summary: Toaster: add layer button from project configuration page remains sensitive if you select a layer with dependencies
Product: [Build System, Metadata & Runtime] Toaster Reporter: Alexandru Roman <alexandru.costinx.roman>
Component: toasterAssignee: Belen Barros Pena <belen.barros.pena>
Status: VERIFIED WORKSFORME QA Contact: Alexandru Roman <alexandru.costinx.roman>
Severity: normal    
Priority: Low CC: belen.barros.pena, jessica.zhang, stanciux.mihail
Version: 2.1   
Target Milestone: 2.1   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)
Attachments:
Description Flags
add button none

Description Alexandru Roman 2015-10-20 11:52:26 UTC
Created attachment 2807 [details]
add button

Appears on master: 8578bc17b54da97d42b257b3c8f398ac52b91a9f

Step to reproduce:
1. Open toaster
2. Click on a project or create a new one
3. In the text box from layers search for a layer with dependencies like: meta-crystalforest
4. select the suggestion
5. click on the Add button
6. A pop-up will appear telling you about dependencies. Click Cancel

The Add button should be inactive. Actually if you click on add button again toaster will try to add the selected layer again.
Comment 1 Elliot Smith 2016-02-23 10:27:33 UTC
I think this is by design: if you click cancel in the popup when prompted to add the dependencies, you're cancelling adding the layer you initially selected, as well as cancelling adding its dependencies. So the "Add layer" button should remain active, as you haven't added any layers.

It may be that we need to make it clearer in the popup that you haven't added the layer yet, until you click "Add layers" in the popup. Belen may want to comment on this.
Comment 2 Elliot Smith 2016-02-23 10:28:22 UTC
Belen, do you have any comment? If you think the feature is working as intended, I'd suggest closing this.
Comment 3 Belen Barros Pena 2016-02-23 14:15:25 UTC
I can no longer reproduce this (using the toaster-next branch). When I click the 'cancel' button in the layer dependencies dialog, the add layer text field is cleared, and the 'add layer' button is inactive.
Comment 4 Alexandru Roman 2016-03-10 09:22:31 UTC
Can't reproduce it anymore on master: 5ac3dc76a5afc2ed35b1abfc8e330e0c580eadf0
Put this on resolved worksforme
Comment 5 Alexandru Roman 2016-03-10 09:24:05 UTC
Verified.