| Summary: | separate code generating python manifest file from manifest information and improve the manifest generation | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] OE-Core | Reporter: | wrobell | ||||||||||||||
| Component: | devtools / tool chain | Assignee: | Ross Burton <ross.burton> | ||||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||||
| Severity: | enhancement | ||||||||||||||||
| Priority: | Medium | CC: | alejandro.hernandez, benjamin.esquivel, leonardo.sandoval.gonzalez, meta.mr.watcher, meta.watcher, wrobell | ||||||||||||||
| Version: | 2.0 | ||||||||||||||||
| Target Milestone: | 2.5 M2 | ||||||||||||||||
| Hardware: | All | ||||||||||||||||
| OS: | Multiple | ||||||||||||||||
| Whiteboard: | |||||||||||||||||
| OS type for building Yocto: | --- | Type of Regression: | --- | ||||||||||||||
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 2869 [details]
Python 3.5 manifest data
Created attachment 2870 [details]
Manifest generation code
Created attachment 2871 [details]
Python 3.5 manifest data
Created attachment 2872 [details]
Manifest generation code
Hmm, just noticed - you say the script itself requires Python 3.x (which might be an issue for us, at least at the moment) but your example shows running it under python2... ? Created attachment 2873 [details]
Manifest generation script (python 2 and py3k compatible)
the example of running the script - copy&paste from wrong terminal anyway, attached new version of the manifest file generation script. this version works with both python 2 and py3k. Moving to 2.4 due to workload. Alex, is this something already covered by your recent work on manifest generation? (In reply to comment #9) > Alex, is this something already covered by your recent work on manifest > generation? Yes, everything here will be covered, assigning it to me. Done, but moving to 2.5 per Richard's request Fixed in oe-core 3328211afdef8ffb00dd4dff1143959d5412b075. |
Created attachment 2868 [details] Manifest generation code Python manifest file is generated with generate-manifest-*.py scripts. The scripts have several issues - very long manifest lines are generated, so mailing list is rejecting each patch against the manifest file (I was requested once to send patch against both the manifest generation code and the generated manifest file as well) - the script has 388 lines and 381 PEP-8 violations - the manifest input data and code is coupled together, so we need new script for different versions of python (2.7 vs. 3.x) I am attaching rewritten script, which uses separate manifest input file (in JSON format). The attached manifest file is for Python 3.5 (should work for Python 3.4 as well). Usage: $ python2 ./generate-manifest.py < python-3.5-manifest-input.json > python-3.5-manifest.inc The script itself requires Python 3.x.