Bug 9011

Summary:	Default sorting for recipes page not showing properly
Product:	[Build System, Metadata & Runtime] Toaster	Reporter:	Alexandru Roman <alexandru.costinx.roman>
Component:	toaster	Assignee:	Elliot Smith <elliot.smith>
Status:	RESOLVED FIXED	QA Contact:	Alexandru Roman <alexandru.costinx.roman>
Severity:	minor
Priority:	Medium	CC:	belen.barros.pena, jessica.zhang, stanciux.mihail
Version:	2.1
Target Milestone:	2.2 M1
Hardware:	x86
OS:	Multiple
Whiteboard:
OS type for building Yocto:	---	Type of Regression:	Unknown (Hard to categorize)
Verified:		Documentation change:	No (bug/feature does not impact docs)

Description Alexandru Roman 2016-01-28 14:47:28 UTC

Appears on 2.1_M.1.RC1: 3d2c0f5902cacf9d8544bf263b51ef0dd1a7218c

Step to reproduce:

1. Enter a project page
2. Go to Image recipes or software recipes
3. Sort the table by layer
4. From Edit columns hide layer column

Expected result:
Revert the sorting to the default sorting (i.e. "Recipe")

Observed result:
Table is sort by default column but the column is not bold and the arrow is missing.

If you check the layer column again the default sorting remains but the "layer" appears bold.

Comment 1 Alexandru Roman 2016-01-29 09:03:41 UTC

This behavior appears also in all project builds table.

Comment 2 Elliot Smith 2016-02-23 14:28:12 UTC

See also bug 7198, which is related.

Comment 3 Elliot Smith 2016-02-29 14:39:24 UTC

See also bug 8791, which is related.

Comment 4 Elliot Smith 2016-03-29 08:57:29 UTC

Belen tested a previous version of my patches for this, with the following result:

So, tested this across Toaster (if a table is not on the list, it means
the bug doesn't apply because either only one column is sortable, or
because none of the sortable columns can be hidden using the 'edit
columns' menu).

It seems to work in all the tables implemented with ToasterTable

* Image recipes
* Image recipe details (packages included)
* Custom image recipe details (add | remove packages)
* Software recipes
* Machines
* Layers
* All builds
* Project builds

If the scope of the patch is only tables implemented with ToasterTable,
then this is good to go. For the sake of completion, this is working in
the following tables *not* implemented with ToasterTable

* Recipes
* Packages

It doesn't seem to work in the following tables *not* implemented with
ToasterTable

* Packages included
* Tasks (and by extension Time, CPU time and disk I/O since they are the
same as the tasks table).

Comment 5 Elliot Smith 2016-04-07 13:21:18 UTC

Now fixed for all cases; see https://lists.yoctoproject.org/pipermail/toaster/2016-March/004329.html for review request.

Comment 6 Elliot Smith 2016-04-21 11:06:26 UTC

Now in bitbake master.

Comment 7 Alexandru Roman 2016-04-21 11:24:07 UTC

I can still reproduce it for All builds table and Project builds table.
Fixed for Image recipes table and Software recipes table.

Comment 8 Elliot Smith 2016-04-22 11:36:09 UTC

Sent another patch to mailing list:
https://lists.yoctoproject.org/pipermail/toaster/2016-April/004490.html

Comment 9 Belen Barros Pena 2016-04-25 14:44:09 UTC

Last patch didn't make it to 2.1, so moving this bug to 2.2M1

Comment 10 Belen Barros Pena 2016-04-25 15:38:04 UTC

*** Bug 7198 has been marked as a duplicate of this bug. ***