| Summary: | The unique name validation for custom images happens across projects | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] Toaster | Reporter: | Belen Barros Pena <belen.barros.pena> | ||||
| Component: | toaster | Assignee: | Toaster default assignee <toaster> | ||||
| Status: | ACCEPTED --- | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | Low | CC: | belen.barros.pena, david.reyna, jessica.zhang, jose.perez.carranza, sgw, stanciux.mihail | ||||
| Version: | 2.0 | ||||||
| Target Milestone: | Future | ||||||
| Hardware: | x86 | ||||||
| OS: | Multiple | ||||||
| Whiteboard: | |||||||
| OS type for building Yocto: | --- | Type of Regression: | --- | ||||
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |||||
| Bug Depends on: | 7880 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Belen Barros Pena
2016-03-03 19:22:33 UTC
Note that this is because all custom images go into the same folder, with filenames matching the custom image name (e.g. if I create the custom image "mycim", the recipe file would be /home/ell/dev/toaster/poky/build/toaster-custom-images/recipes/mycim.bb). To change this, it would be necessary to include and additional identifier in the path, e.g. the project: /home/ell/dev/toaster/poky/build/toaster-custom-images/recipes/project-1/mycim.bb or an increment on the recipe file basename: /home/ell/dev/toaster/poky/build/toaster-custom-images/recipes/mycim-1.bb or similar. The plan is moving toaster-custom-images inside the project specific build directory, so that you have a toaster-custom-images folder per project. Would that solve the problem without further changes? If yes, that means this bug depends on bug 7880 Yes, that should fix it, as you would have a project-specific directory which is part of the recipe path. While you no longer get an error about duplicate custom image names, all recipe files for all projects still go into build/toaster-custom-images. This may mean that custom image recipe files from different projects are overwriting each other if they have the same name. I also noticed bug 9425 while checking this, which may be a related issue (the downloadable file is expected to be in one location but is actually in a different location). You do see error messages about duplicate custom image names still; not sure what I did earlier when I didn't see the error when I used the same recipe name in two different projects. Posted to Toaster mailing list for review 2016-04-11: https://lists.yoctoproject.org/pipermail/toaster/2016-April/004425.html Leaving until after Bootstrap 3 migration, as it touches the UI code. Now that the Bootstrap 3 work has been put aside momentarily, I sent a reminder to review this: https://lists.yoctoproject.org/pipermail/toaster/2016-April/004468.html Created attachment 3285 [details]
this zip holds two snapshots of customize image goo in different projects
This was verified in commit 6f0c5537e02c59e1c8f3b08f598dc049ff8ee098 To verify I took the following steps: 1. Create a project. 2. Create a custom image with name 'goo' in this project; it should work. 3. Try to create another custom image called 'goo' in this project; it should fail. 4. Try to create a custom image called 'core-image-minimal' in this project; it should fail. 5. Create another project. 6. Create a custom image called 'goo' in the second project; it should work. I've just reproduced this on master (627d01997fcf6a0581d88047735769ffb2592b82) and toaster-next (2a127b1a6cd3df47879bda5e0d7bb123484013cb), so reopening Belen, can you verify that you have reproduced the bug using the steps in the original bug report? Or were you doing something else? (In reply to comment #12) > Belen, can you verify that you have reproduced the bug using the steps in > the original bug report? Or were you doing something else? Exactly the same steps as in https://bugzilla.yoctoproject.org/show_bug.cgi?id=9209#c0 |