| Summary: | Vet subprocess calls | ||
|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] OE-Core | Reporter: | Ross Burton <ross.burton> |
| Component: | core | Assignee: | Stephano Cetola <stephano> |
| Status: | VERIFIED FIXED | QA Contact: | Juan Ramos <juan.fernandox.ramos.frayle> |
| Severity: | enhancement | ||
| Priority: | Medium+ | CC: | benjamin.esquivel, jose.perez.carranza, joshuagloe, meta.mr.watcher, meta.watcher, richard.purdie, sgw |
| Version: | 2.1 | ||
| Target Milestone: | 2.3 M1 | ||
| Hardware: | All | ||
| OS: | Multiple | ||
| See Also: | https://bugzilla.yoctoproject.org/show_bug.cgi?id=10383 | ||
| Whiteboard: | |||
| OS type for building Yocto: | --- | Type of Regression: | --- |
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |
|
Description
Ross Burton
2016-03-24 14:29:03 UTC
We should also vet oe.path.check_output() calls This is a proper yak shaver * Review bb.process in light of Python 3.4's subprocess implementation, in particular some of the issues in py2 have been fixed so some cruft can likely be removed * Note that Python 3.5 has a subprocess.run() convenience function that does all sorts of useful magic. Maybe it would be sensible to clone that API in bb.process() for consistency and the ability to just use subprocess.run() in the future * Review subprocess calls, moving as much as possible to lists instead of strings with shell=True, and show stderr on error. There were just two callers of oe.path.check_output, so I just sent a patch to use subprocess directly. Stephano, I appreciate this bug is rather vague, hopefully comment #2 makes some sense. Feel free to talk to me if you're not sure about anything! oe.utils.getstatusoutput() is a wrapper around subprocess.getstatusouput() in Py3, which is basically deprecated and behaves almost entirely unlike run(). This also should be gutted. Cleaned up sub.call and sub.check_output calls in meta/lib/oe/. Looking at Popen calls next. As I slowly pull apart all the strings, pipes, and redirects in package_manager.py, I am reminded of a rat infested spool of razorwire surrounded by bees. With any luck this should be done tomorrow. Checked in the needed changes. According to Stephano, any test of the “package” and “package_manager” features in OE will test the changes. Since these are present in nightly test, Im changing this to verified. |