Bug 9587

Summary: 4.1.x: gpio-pca953x.c fails to compile without CONFIG_ACPI
Product: [Yocto Project Subprojects] Kernel Reporter: George McCollister <george.mccollister>
Component: linux-yoctoAssignee: California Sullivan <california.l.sullivan>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Medium    
Version: 2.1   
Target Milestone: 2.2   
Hardware: Other   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: Regression (Used to work)
Verified: Documentation change: No (bug/feature does not impact docs)

Description George McCollister 2016-05-04 19:24:49 UTC 
Due to the following commit the driver doesn't compile without CONFIG_ACPI:
http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-4.1/commit/drivers/gpio/gpio-pca953x.c?h=standard/base&id=94bfb66b8887ec17a46163ad02af60ff02ab2d73

| /home/georgem/buildbot/slave/ntel_krogoth_orionlxm/build/build/tmp-glibc/work-shared/orionlxm/kernel-source/drivers/gpio/gpio-pca953x.c: In function 'pca953x_setup_int3491':
| /home/georgem/buildbot/slave/ntel_krogoth_orionlxm/build/build/tmp-glibc/work-shared/orionlxm/kernel-source/drivers/gpio/gpio-pca953x.c:118:17: error: implicit declaration of function 'acpi_device_uid' [-Werror=implicit-function-declaration]
|   if (kstrtouint(acpi_device_uid(adev), 0, &uid) || !uid--)
|                  ^
| /home/georgem/buildbot/slave/ntel_krogoth_orionlxm/build/build/tmp-glibc/work-shared/orionlxm/kernel-source/drivers/gpio/gpio-pca953x.c:118:17: warning: passing argument 1 of 'kstrtouint' makes pointer from integer without a cast [-Wint-conversion]
| In file included from /home/georgem/buildbot/slave/ntel_krogoth_orionlxm/build/build/tmp-glibc/work-shared/orionlxm/kernel-source/include/linux/list.h:8:0,
|                  from /home/georgem/buildbot/slave/ntel_krogoth_orionlxm/build/build/tmp-glibc/work-shared/orionlxm/kernel-source/include/linux/module.h:9,
|                  from /home/georgem/buildbot/slave/ntel_krogoth_orionlxm/build/build/tmp-glibc/work-shared/orionlxm/kernel-source/drivers/gpio/gpio-pca953x.c:14:
| /home/georgem/buildbot/slave/ntel_krogoth_orionlxm/build/build/tmp-glibc/work-shared/orionlxm/kernel-source/include/linux/kernel.h:331:18: note: expected 'const char *' but argument is of type 'int'
|  int __must_check kstrtouint(const char *s, unsigned int base, unsigned int *res);
|                   ^
| cc1: some warnings being treated as errors
| /home/georgem/buildbot/slave/ntel_krogoth_orionlxm/build/build/tmp-glibc/work-shared/orionlxm/kernel-source/scripts/Makefile.build:258: recipe for target 'drivers/gpio/gpio-pca953x.o' failed
Comment 1 California Sullivan 2016-07-27 17:17:19 UTC 
Some inappropriate Galileo-specific patches were merged into the standard/base kernel causing this bug. They will be removed.
Comment 2 California Sullivan 2016-10-04 23:33:21 UTC 
These patches have been removed from standard/base in both the 4.4 and 4.1 kernels.

See here: https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=8c5ac488f1e243617d9a09b7686329e0e89f8242