Bug 9609

Summary: 4.1.x: musb fails to compile
Product: [Yocto Project Subprojects] Kernel Reporter: George McCollister <george.mccollister>
Component: linux-yoctoAssignee: Bruce Ashfield <bruce.ashfield>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Medium CC: randy.macleod
Version: 2.1   
Target Milestone: 2.3 M3   
Hardware: BeagleBone   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)

Description George McCollister 2016-05-09 18:39:00 UTC
musb fails to compile on linux-yocto 4.1.

| /home/georgem/buildbot/slave/krogoth_orionlxm/build/build/tmp-glibc/work-shared/orionlxm/kernel-source/drivers/usb/musb/musb_dsps.c: In function 'dsps_create_musb_pdev':
| /home/georgem/buildbot/slave/krogoth_orionlxm/build/build/tmp-glibc/work-shared/orionlxm/kernel-source/drivers/usb/musb/musb_dsps.c:750:8: error: 'struct musb_hdrc_config' has no member named 'maximum_speed'
|   config->maximum_speed = usb_get_maximum_speed(&parent->dev);
|         ^
| /home/georgem/buildbot/slave/krogoth_orionlxm/build/build/tmp-glibc/work-shared/orionlxm/kernel-source/drivers/usb/musb/musb_dsps.c:751:16: error: 'struct musb_hdrc_config' has no member named 'maximum_speed'
|   switch (config->maximum_speed) {
|                 ^
| /home/georgem/buildbot/slave/krogoth_orionlxm/build/build/tmp-glibc/work-shared/orionlxm/kernel-source/drivers/usb/musb/musb_dsps.c:760:9: error: 'struct musb_hdrc_config' has no member named 'maximum_speed'
|    config->maximum_speed = USB_SPEED_HIGH;
|          ^
| /home/georgem/buildbot/slave/krogoth_orionlxm/build/build/tmp-glibc/work-shared/orionlxm/kernel-source/scripts/Makefile.build:258: recipe for target 'drivers/usb/musb/musb_dsps.o' failed
| make[5]: *** [drivers/usb/musb/musb_dsps.o] Error 1
| /home/georgem/buildbot/slave/krogoth_orionlxm/build/build/tmp-glibc/work-shared/orionlxm/kernel-source/scripts/Makefile.build:403: recipe for target 'drivers/usb/musb' failed

Cherry-pick 9b7537642cb6ad400ee4a95114582ba758b3009c to fix the problem
Comment 1 Bruce Ashfield 2016-05-12 14:48:34 UTC
Simply send the patch to linux-yocto. Going through bugzilla when the fix is
already known is just overhead.
Comment 2 Bruce Ashfield 2017-01-11 16:36:34 UTC
commit 403eda4633e9037fb715d0d1e8ae847b2bd0651a
Author: Bin Liu <b-liu@ti.com>
Date:   Wed Sep 9 13:17:23 2015 -0500

    usb: musb: set the controller speed based on the config setting
    
    Set the Power register HSENAB bit based on musb->config->maximum_speed,
    so that the glue layer can control MUSB to work in high- or full-speed.
    
    Signed-off-by: Bin Liu <b-liu@ti.com>
    Signed-off-by: Felipe Balbi <balbi@ti.com>
    Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>


git branch --contains 403eda4633e9037fb715d0d1e8ae847b2bd0651a
  standard/actions-s500
  standard/arm-versatile-926ejs
  standard/axxia/base
* standard/base
  standard/beagleboard
  standard/beaglebone
  standard/edgerouter
  standard/fsl-ls10xx
  standard/fsl-mpc8315e-rdb
  standard/intel/4.1.27/leaf-hill
  standard/intel/4.1.27/leaf-hill-old
  standard/intel/base
  standard/mti-malta32
  standard/mti-malta64
  standard/next
  standard/preempt-rt/axxia/base
  standard/preempt-rt/base
  standard/preempt-rt/intel/base
  standard/preempt-rt/next
  standard/qemuarm64
  standard/qemuppc
  standard/tiny/base
  standard/tiny/common-pc
  standard/tiny/intel/base
  standard/xilinx-zynq