| Summary: | patchtest: must be able to test the series on every branch specified on mbox summary | ||
|---|---|---|---|
| Product: | [Yocto Project Subprojects] Patchwork/Patchtest | Reporter: | Leonardo Sandoval Gonzalez <leonardo.sandoval.gonzalez> |
| Component: | Patchtest | Assignee: | Leonardo Sandoval Gonzalez <leonardo.sandoval.gonzalez> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | Medium | CC: | bluelightning, sgw |
| Version: | 2.3 | ||
| Target Milestone: | 2.5 | ||
| Hardware: | x86 | ||
| OS: | Multiple | ||
| Whiteboard: | |||
| OS type for building Yocto: | --- | Type of Regression: | --- |
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |
| Bug Depends on: | |||
| Bug Blocks: | 10716 | ||
|
Description
Leonardo Sandoval Gonzalez
2016-07-14 21:22:27 UTC
This is nice feature but current release is already too loaded with patchtest work and currently work is focused on stabilization and the test suite. Moving it to next release. At 2.4, the focus is on the python 2 to python 3 migration, tinfoil usage and stabilization of these two. So moving it to 2.5 Right now, we have the following commit to stop sending false positives, but need to better handle by indicating patchtest which branch to use, so test test_series_merge_on_head is generic commit d2aba545588264e1135fa9b651145467178e4c8a Author: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com> Date: Fri Jun 23 08:57:55 2017 -0700 test_mbox_merge: skip test on stable branches Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com> diff --git a/tests/test_mbox_merge.py b/tests/test_mbox_merge.py index 6d70d6c..04039b1 100644 --- a/tests/test_mbox_merge.py +++ b/tests/test_mbox_merge.py @@ -32,7 +32,18 @@ class Merge(base.Base): def test_series_merge_on_head(self): if not pti.repo.ismerged: - commithash, author, date, shortlog = headlog() - self.fail('Series does not apply on top of target branch', - 'Rebase your series on top of targeted branch', - data=[('Targeted branch', '%s (currently at %s)' % (pti.repo.branch, commithash))]) + + # TODO: in order to stop sending false-positives, do this check on + # patchtest-oe instead of selecting the correct branch from patchtest. + # Currently patchtest is not able to test on non-master branches, + # so we need to avoid testing on patches targeted for the following + # stable releases + stable_releases = ['krogoth', 'morty', 'pyro'] + subjects = [commit.subject for commit in self.commits] + for release in stable_releases: + if release in subjects[0]: + self.skip('Non-master branch %s, skip test' % release, data=[('patch', pti.repo.patch)]) + else: + commithash, author, date, shortlog = headlog() + self.fail('Series does not apply on top of target branch', 'Rebase your series on top of targeted branch', + data=[('Targeted branch', '%s (currently at %s)' % (pti.repo.branch, commithash))]) This enhancement is partially completed in the framework. By partially I meant that if a single series is intended for multiple branches, then just one branch will be tested (the first that match with a oe-core branch, i.e. master, pyro, rocko, etc.). IMO, this this good enough because series usually are targeted to a single branch, not multiple, so patchtest will do its job as expected. |