Bug 9981

For yocto-worker/buildbot.tac we should be able towrite Python to get the hostname and use it. Untested, but I think something like this should work:

import socket
workername = socket.gethostname()

Since the upgrade to buildbot-worker 1.1.1 and beyond, there are many features 
added into buildbot-worker. 
Hence would like to revisit this on why we are trying to get the hostname from the workers and where we might use this info.

we could add in a possible patch on the following:

import socket
workername = socket.gethostname()

or use

import netifaces where we can access the network interfaces on each worker.

hence today the way I get this information is running a custom startup script
as part of buildbot-worker-update

$ buildbot-worker-update <path worker created> <owner name> <owner email>
$ buildbot-worker-update ~/yocto-worker "Michael Halstead" "michael@yoctoproject.org"

This will update the worker info on its Kernel version, Hostname info, etc into
yocto-worker/info/host

Patches describe to autoset the buildbot worker with the system hostname.
This helps to reduce the need to supply worker name during create-worker on all other worker cluster on the same network.
Therefore the command is simplify as:

buildbot-worker create-worker --umask=0o22 <path> <server>:<port> <password>

Signed-off-by: Aaron Chan <aaron.chun.yew.chan@intel.com>
---
 worker/buildbot_worker/scripts/runner.py | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/worker/buildbot_worker/scripts/runner.py b/worker/buildbot_worker/scripts/runner.py
index 06d369331..827dca470 100644
--- a/worker/buildbot_worker/scripts/runner.py
+++ b/worker/buildbot_worker/scripts/runner.py
@@ -24,6 +24,7 @@ import os
 import re
 import sys
 import textwrap
+import socket
 
 from twisted.python import log
 from twisted.python import reflect
@@ -176,12 +177,12 @@ class CreateWorkerOptions(MakerBase):
             "[options] <basedir> <master> <name> <passwd>"
 
     def parseArgs(self, *args):
-        if len(args) != 4:
+        if len(args) != 3:
             raise usage.UsageError("incorrect number of arguments")
-        basedir, master, name, passwd = args
+        basedir, master, passwd = args
         self['basedir'] = basedir
         self['host'], self['port'] = self.validateMasterArgument(master)
-        self['name'] = name
+        self['name'] = socket.gethostname()
         self['passwd'] = passwd
 
     def postOptions(self):
--
2.11.0

The patch has been send to Buildbot maintainer Pierre Tardy for review at 
https://github.com/tardyp/buildbot

On worker end, we run,
$ buildbot-worker create-worker <path> <server>:<port> <password>

With this patch buildbot-worker will create the worker directory and buildbot.tac without the need to supply worker name, instead worker name is set
based on system hostname where worker is created.

This ticket will be set to resolved.

That is a fine solution. This was filed when we were using autobuilder1 and the problems it would have solved are no longer and issue.