Bug 10286

Summary: Deleting builds and projects should be a modal process
Product: [Build System, Metadata & Runtime] Toaster Reporter: Belen Barros Pena <belen.barros.pena>
Component: toasterAssignee: Michael Wood <michael.g.wood>
Status: RESOLVED FIXED QA Contact: Libertad <libertad.gonzalez.de.la.cruz>
Severity: normal    
Priority: Medium CC: belen.barros.pena, jessica.zhang, stanciux.mihail
Version: unspecified   
Target Milestone: 2.2 M4   
Hardware: x86   
OS: Multiple   
Whiteboard: GUI design pending
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)
Bug Depends on: 10289    
Bug Blocks:    
Attachments:
Description Flags
build_artifact_does_not_exist.png none

Description Belen Barros Pena 2016-09-15 15:38:54 UTC 
Created attachment 3422 [details]
build_artifact_does_not_exist.png

Apologies for missing this when designing the feature. 

It turns out deleting a build can take a little while (at least when you are using sqlite). Sagely, Michael added a progress indicator. However, while the deletion is in progress, you can still dismiss the "delete" dialog, and navigate around the data for the build you are deleting ... until the deletion completes. At that point you will get an ugly error

DoesNotExist at /toastergui/build/11/recipes/
Build matching query does not exist.

To avoid this we should:

1. Make the delete process truly modal: you should not be able to dismiss the 'delete' modal dialog. Apparently, properties exist to do this (http://stackoverflow.com/questions/9894339/disallow-twitter-bootstrap-modal-window-from-closing)

2. Create a custom message for deleted object urls, as we do for deleted build artifacts
Comment 1 Belen Barros Pena 2016-09-16 10:49:54 UTC 
Forgot to mention: we also need to remove / disable the "Cancel" link in the modal dialog once you click "Delete".