Bug 107

Summary: TCF RSE plug-in not handle the situation if the remote agent does NOT support terminal service
Product: [Yocto Project Subprojects] Eclipse Plugin Reporter: Lianhao Lu <lianhao.lu>
Component: eclipse-pluginAssignee: Lianhao Lu <lianhao.lu>
Status: CLOSED OBSOLETE QA Contact:
Severity: enhancement    
Priority: Medium CC: jessica.zhang, ke.yu, kevin.tian, laurentiu.serban, lianhao.lu, liping.ke, sgw, shane.wang, song.liu, yp.ep.watcher, yp.watcher
Version: 1.0   
Target Milestone: 1.3 M3   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: ---

Description Lianhao Lu 2010-07-14 18:18:22 UTC
Currently, the TCF RSE plugin doesn't handle the situation if the remote agent does NOT support the terminal service, in which case when the user clicks "launch terminal", a new terminal tab is created but nothing happens then.

An exception is thrown in this case, but it seems not being handled.

org.eclipse.rse.services.clientserver.messages.SystemMessageException: Remote peer does not support org.eclipse.tm.internal.tcf.terminals.ITerminalsService service
	at org.eclipse.tm.internal.tcf.rse.TCFRSETask.getS(TCFRSETask.java:48)
	at org.eclipse.tm.internal.tcf.rse.shells.TCFTerminalShell.<init>(TCFTerminalShell.java:215)
	at org.eclipse.tm.internal.tcf.rse.terminals.TCFTerminalService.launchTerminal(TCFTerminalService.java:35)
	at org.eclipse.rse.internal.terminals.ui.views.RSETerminalConnectionThread.run(RSETerminalConnectionThread.java:55)
TCF shell Service: Connect failed
Exception in thread "Thread-13" java.lang.NullPointerException
	at org.eclipse.rse.internal.terminals.ui.views.RSETerminalConnectionThread.readDataForever(RSETerminalConnectionThread.java:99)
	at org.eclipse.rse.internal.terminals.ui.views.RSETerminalConnectionThread.run(RSETerminalConnectionThread.java:70)
Comment 1 Yongkang You 2010-07-29 18:34:30 UTC
Changed to SDK Plugin/Eclipse component
Comment 2 liping Ke 2010-09-01 19:06:10 UTC
After investigation, I found in RSETerminalConnectThread.java (RSE code, not our part), it did catch the SystemMessageException we throw, but it only "log" the error and go on other jobs. Seems rollback operation is not considered at all in its implementation.

Since it's not our code part, this job can be delayed during our communicating with TCF/RSE community. 

I leave the bug as open and mark it as "enhancement", put it off till "M4". This bug should be kept tracking by us.


Thanks& Regards,
criping
Comment 3 Jessica 2010-09-08 22:24:56 UTC
File an upstream bug
Comment 4 liping Ke 2010-09-13 20:46:02 UTC
Please refer to the bug in upstream bugzilla:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=325188
Comment 5 liping Ke 2011-04-05 22:23:52 UTC
Nobody cares about this bug. We will look@the bug in 1.1 when upgrading RSE versions. If the bug still exists, send a patch to the RSE directly to see whether they would accept the patch.

Thanks& Regards,
criping
Comment 6 Jessica 2012-06-21 18:49:24 UTC
Is this still a valid bug since our extension to agent is upstreamed which means the agent should support the teminal service by default, right?
Comment 7 Lianhao Lu 2012-06-25 08:59:46 UTC
(In reply to comment #6)
> Is this still a valid bug since our extension to agent is upstreamed which
> means the agent should support the teminal service by default, right?

Yes. The terminal service is supported by default now.
Comment 8 Jessica 2012-07-10 17:47:57 UTC
Lianhao,

So can you close the bug since terminal service is by default supported by the agent?
Comment 9 Lianhao Lu 2012-07-11 01:09:35 UTC
obsolete this bug because the terminal service is a default service on upstream tcf-agent.
Comment 10 Laurentiu Serban 2012-08-17 21:47:17 UTC
setting this to verified
Comment 11 Armin Kuster 2019-08-29 15:17:19 UTC
closing