Currently, the TCF RSE plugin doesn't handle the situation if the remote agent does NOT support the terminal service, in which case when the user clicks "launch terminal", a new terminal tab is created but nothing happens then. An exception is thrown in this case, but it seems not being handled. org.eclipse.rse.services.clientserver.messages.SystemMessageException: Remote peer does not support org.eclipse.tm.internal.tcf.terminals.ITerminalsService service at org.eclipse.tm.internal.tcf.rse.TCFRSETask.getS(TCFRSETask.java:48) at org.eclipse.tm.internal.tcf.rse.shells.TCFTerminalShell.<init>(TCFTerminalShell.java:215) at org.eclipse.tm.internal.tcf.rse.terminals.TCFTerminalService.launchTerminal(TCFTerminalService.java:35) at org.eclipse.rse.internal.terminals.ui.views.RSETerminalConnectionThread.run(RSETerminalConnectionThread.java:55) TCF shell Service: Connect failed Exception in thread "Thread-13" java.lang.NullPointerException at org.eclipse.rse.internal.terminals.ui.views.RSETerminalConnectionThread.readDataForever(RSETerminalConnectionThread.java:99) at org.eclipse.rse.internal.terminals.ui.views.RSETerminalConnectionThread.run(RSETerminalConnectionThread.java:70)
Changed to SDK Plugin/Eclipse component
After investigation, I found in RSETerminalConnectThread.java (RSE code, not our part), it did catch the SystemMessageException we throw, but it only "log" the error and go on other jobs. Seems rollback operation is not considered at all in its implementation. Since it's not our code part, this job can be delayed during our communicating with TCF/RSE community. I leave the bug as open and mark it as "enhancement", put it off till "M4". This bug should be kept tracking by us. Thanks& Regards, criping
File an upstream bug
Please refer to the bug in upstream bugzilla: https://bugs.eclipse.org/bugs/show_bug.cgi?id=325188
Nobody cares about this bug. We will look@the bug in 1.1 when upgrading RSE versions. If the bug still exists, send a patch to the RSE directly to see whether they would accept the patch. Thanks& Regards, criping
Is this still a valid bug since our extension to agent is upstreamed which means the agent should support the teminal service by default, right?
(In reply to comment #6) > Is this still a valid bug since our extension to agent is upstreamed which > means the agent should support the teminal service by default, right? Yes. The terminal service is supported by default now.
Lianhao, So can you close the bug since terminal service is by default supported by the agent?
obsolete this bug because the terminal service is a default service on upstream tcf-agent.
setting this to verified
closing