| Summary: | patchwork: pw should not create new revisions from comments/replies containing patch-like content | ||
|---|---|---|---|
| Product: | [Yocto Project Subprojects] Patchwork/Patchtest | Reporter: | Jose Lamego <jose.a.lamego> |
| Component: | Patchwork | Assignee: | Jose Lamego <jose.a.lamego> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Medium | CC: | bluelightning, leonardo.sandoval.gonzalez, patrick.ohly |
| Version: | unspecified | ||
| Target Milestone: | 2.3 M3 | ||
| Hardware: | x86 | ||
| OS: | Multiple | ||
| Whiteboard: | |||
| OS type for building Yocto: | --- | Type of Regression: | --- |
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |
|
Description
Jose Lamego
2016-11-28 20:02:12 UTC
How will you tell the difference between a genuine patch sent in reply to an earlier version (or even in reply to a discussion) and a reply with erroneous patch content? (In reply to comment #1) > How will you tell the difference between a genuine patch sent in reply to an > earlier version (or even in reply to a discussion) and a reply with > erroneous patch content? Exactly what I was wondering before filing this bug. I guess only after some investigation/testing I'll be able to answer. Another example: https://patchwork.openembedded.org/series/4235/ An example of a revision created from a reply (a ping, in this case) is at: https://patchwork.openembedded.org/series/4578/ and a revision created from reply: https://patchwork.openembedded.org/series/4506/#rev2 "[PATCH" prefix is now mandatory for any email message to be considered as a possible new patch, and any message starting with any character other than square bracket will be considered only as a possible comment (for example, messages starting with "Re:" or "Fwd:"). This guideline will avoid the reported issue. This change is implemented in: http://git.yoctoproject.org/cgit/cgit.cgi/patchwork/commit/?id=1a096ecdec71ad20e47af075e0126f77c54e7ec9 |