Bug 10739 - patchwork: pw should not create new revisions from comments/replies containing patch-like content
Summary: patchwork: pw should not create new revisions from comments/replies containin...
Status: RESOLVED FIXED
Alias: None
Product: Patchwork/Patchtest
Classification: Yocto Project Subprojects
Component: Patchwork (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium normal
Target Milestone: 2.3 M3
Assignee: Jose Lamego
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-11-28 20:02 UTC by Jose Lamego
Modified: 2017-12-06 17:18 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Lamego 2016-11-28 20:02:12 UTC
Pathchwork should identify message-replies that contain patch-like content and not create new series revisions from them.

An example of such is revision 2 at:
https://patchwork.openembedded.org/series/3843/
Comment 1 Paul Eggleton 2016-11-28 20:33:12 UTC
How will you tell the difference between a genuine patch sent in reply to an earlier version (or even in reply to a discussion) and a reply with erroneous patch content?
Comment 2 Jose Lamego 2016-11-28 20:39:46 UTC
(In reply to comment #1)
> How will you tell the difference between a genuine patch sent in reply to an
> earlier version (or even in reply to a discussion) and a reply with
> erroneous patch content?

Exactly what I was wondering before filing this bug. I guess only after some investigation/testing I'll be able to answer.
Comment 3 Jose Lamego 2016-12-08 14:46:35 UTC
Another example: https://patchwork.openembedded.org/series/4235/
Comment 4 Jose Lamego 2017-01-04 19:42:05 UTC
An example of a revision created from a reply (a ping, in this case) is at:
https://patchwork.openembedded.org/series/4578/

and a revision created from reply:
https://patchwork.openembedded.org/series/4506/#rev2
Comment 5 Jose Lamego 2017-02-10 17:32:15 UTC
"[PATCH" prefix is now mandatory for any email message to be considered as a possible new patch, and any message starting with any character other than square bracket will be considered only as a possible comment (for example, messages starting with "Re:" or "Fwd:"). This guideline will avoid the reported issue.

This change is implemented in:
http://git.yoctoproject.org/cgit/cgit.cgi/patchwork/commit/?id=1a096ecdec71ad20e47af075e0126f77c54e7ec9