Bug 10823

Summary: A V2 series wasn't detected as such
Product: [Yocto Project Subprojects] Patchwork/Patchtest Reporter: Ross Burton <ross.burton>
Component: PatchworkAssignee: Jose Lamego <jose.a.lamego>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: Medium+ CC: leonardo.sandoval.gonzalez
Version: unspecified   
Target Milestone: 2.3 M3   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)

Description Ross Burton 2016-12-19 11:02:32 UTC 
https://patchwork.openembedded.org/series/4459/ is a series of 8 patches without a cover letter.

https://patchwork.openembedded.org/series/4462/ is a V2 of the same series, now 10 patches, without a cover letter.

I don't expect patchworks to identify that 4462 is v2 of 4459 as they don't have cover letters, but the patches inside can be identified.  Same author, same subject, v2 all have V2 tag.  Patchworks should be able to mark all of the v1 patches are superseded.
Comment 1 Jose Lamego 2017-02-10 01:37:34 UTC 
I have two preliminary findings on this report:

1 - The provided example of a non-detected v2 series (4462) does not comply with current OE-patchwork guidelines to be considered a valid series-continuation (optionally, you can skip the following details on why and go to section 2 for a valid case):
    While all of the 8 patches in series 4459 do comply with OE's guidelines
    for patch submission (reference: [1]), all of the 10 patches in series 4462
    do not: all of the later are missing "PATCH" prefix in the Subject, which results
    in a different title as seen by patchwork, hence the new Series created.
    Additionally, a fix was implemented to make mandatory the "PATCH" prefix in
    Subject field for any email to be considered as possible patch (reference:
    [2]), which would have avoid for any of the mentioned patches to be
    processed in patchwork at all (if sent after the mentioned implementation).
    Question for Leo: Is there a test in Patchtest to verify Subject in email?
    If not, please consider feasibility for one.

2 - An example of a v2 series that may be considered as a valid series-continuation that was not appended to the original series is:
https://patchwork.openembedded.org/series/5082/
where all of the patches have same Title as the respective v1's in
https://patchwork.openembedded.org/series/5081
However, the email Subject field is missing a space between the "PATCH" and "v2" prefixes, and patchwork failed to parse them appropriately (this is why the patch names are displayed starting with "[PATCHv2]...".
I will develop a fix to avoid this.


References:
[1] http://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Sending_patches

[2] https://bugzilla.yoctoproject.org/show_bug.cgi?id=10764
Comment 2 Jose Lamego 2017-02-10 17:07:30 UTC 
Patch can be seen at:

https://lists.yoctoproject.org/pipermail/yocto/2017-February/034478.html

this is implemented in patchwork-staging.
Comment 3 Jose Lamego 2017-02-10 17:15:19 UTC 
Leo mentioned that patchtest process only series already existing in patchwork, therefore, upon implementation of the mentioned change, messages that do not comply with the "PATCH" prefix requirement will not be considered as patches nor tested.