Bug 10764 - patchwork: Make "PATCH" prefix in subject mandatory for emails to be considered patches
Summary: patchwork: Make "PATCH" prefix in subject mandatory for emails to be consider...
Status: RESOLVED FIXED
Alias: None
Product: Patchwork/Patchtest
Classification: Yocto Project Subprojects
Component: Patchwork (show other bugs)
Version: 2.3
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 2.3 M2
Assignee: Jose Lamego
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-12-05 14:26 UTC by Jose Lamego
Modified: 2017-12-06 17:19 UTC (History)
6 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Lamego 2016-12-05 14:26:00 UTC
Patchwork may incorrectly identify emails containing patch-like content as patches. For example:
https://patchwork.openembedded.org/patch/134627/

Patchwork must only consider as patches those messages that include the [PATCH.*] prefix in the subject.
Comment 1 Jose Lamego 2017-01-06 23:06:28 UTC
Patch can be view in:
https://lists.yoctoproject.org/pipermail/yocto/2017-January/033761.html

it is being tested in staging instance at:
https://patchwork-staging.openembedded.org/
Comment 2 Jose Lamego 2017-01-09 22:41:07 UTC
Patrick suggested in [1] that patch should also rule out email messages with a subject line that do not start with an approved OE-layer prefix (for example: "Re: " and "Fwd: ").

I've requested feedback for this approach [2] before implementing a test in the staging instance.

[1] https://lists.yoctoproject.org/pipermail/yocto/2017-January/033778.html
[2] https://lists.yoctoproject.org/pipermail/yocto/2017-January/033797.html
Comment 3 Jose Lamego 2017-01-11 17:04:45 UTC
A v2 patch can be seen in 
https://lists.yoctoproject.org/pipermail/yocto/2017-January/033835.html

this is implemented for testing in the staging instance:
https://patchwork-staging.openembedded.org/
Comment 4 Jose Lamego 2017-01-16 20:39:57 UTC
This has been implemented in production patchwork:
http://git.yoctoproject.org/cgit/cgit.cgi/patchwork/commit/?id=1a096ecdec71ad20e47af075e0126f77c54e7ec9