| Summary: | source code lines should not exceed more than 80 characters | ||
|---|---|---|---|
| Product: | [Yocto Project Subprojects] Patchwork/Patchtest | Reporter: | Leonardo Sandoval Gonzalez <leonardo.sandoval.gonzalez> |
| Component: | Patchtest Testsuite | Assignee: | Leonardo Sandoval Gonzalez <leonardo.sandoval.gonzalez> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | Medium+ | CC: | benjamin.esquivel, bluelightning, mariano.lopez, ross.burton |
| Version: | unspecified | ||
| Target Milestone: | 2.3 M4 | ||
| Hardware: | x86 | ||
| OS: | Multiple | ||
| Whiteboard: | |||
| OS type for building Yocto: | --- | Type of Regression: | --- |
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |
|
Description
Leonardo Sandoval Gonzalez
2017-01-04 22:07:38 UTC
There are a *lot* of recipes that exceed 80 character lines, because this isn't 1970 anymore. :) A limit of something like 160 to check that recipes are not using giant lines is more realistic IMHO. (In reply to comment #1) > There are a *lot* of recipes that exceed 80 character lines, because this > isn't 1970 anymore. :) Indeed, now we have vsplit in vim :) (In reply to comment #1) > There are a *lot* of recipes that exceed 80 character lines, because this > isn't 1970 anymore. :) > > A limit of something like 160 to check that recipes are not using giant > lines is more realistic IMHO. Correct, that's why I mentioned to do some exploration first. Thanks for providing that limit, that is in fact more realistic. (In reply to comment #1) > There are a *lot* of recipes that exceed 80 character lines, because this > isn't 1970 anymore. :) I guess the coding style guides haven't been updated since. > A limit of something like 160 to check that recipes are not using giant > lines is more realistic IMHO. my full screen terminal can handle 279 chars yet every time I open a new terminal window it comes at 80 chars wide. I think it is better to stick to the standards but recipes could be a 'special' case. Fixed by http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe/commit/?id=cabfb858051a6eaa29d1fa6a6e39e558894f47c7 max length set to 160. |