Bug 10878 - source code lines should not exceed more than 80 characters
Summary: source code lines should not exceed more than 80 characters
Status: RESOLVED FIXED
Alias: None
Product: Patchwork/Patchtest
Classification: Yocto Project Subprojects
Component: Patchtest Testsuite (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium+ enhancement
Target Milestone: 2.3 M4
Assignee: Leonardo Sandoval Gonzalez
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2017-01-04 22:07 UTC by Leonardo Sandoval Gonzalez
Modified: 2017-12-06 17:22 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Leonardo Sandoval Gonzalez 2017-01-04 22:07:38 UTC
perhaps this bug overlap  bug 10789 but if not, suite should have its own test case checking for long (source code) lines. Before setting a hardcoded length (80) the current tracked code should be explored and see current max lengths and community guidelines on this area.
Comment 1 Ross Burton 2017-01-05 11:15:51 UTC
There are a *lot* of recipes that exceed 80 character lines, because this isn't 1970 anymore. :)

A limit of something like 160 to check that recipes are not using giant lines is more realistic IMHO.
Comment 2 Mariano Lopez 2017-01-05 15:20:19 UTC
(In reply to comment #1)
> There are a *lot* of recipes that exceed 80 character lines, because this
> isn't 1970 anymore. :)

Indeed, now we have vsplit in vim :)
Comment 3 Leonardo Sandoval Gonzalez 2017-01-05 15:22:07 UTC
(In reply to comment #1)
> There are a *lot* of recipes that exceed 80 character lines, because this
> isn't 1970 anymore. :)
> 
> A limit of something like 160 to check that recipes are not using giant
> lines is more realistic IMHO.

Correct, that's why I mentioned to do some exploration first. Thanks for providing that limit, that is in fact more realistic.
Comment 4 Benjamin Esquivel 2017-01-05 16:21:07 UTC
(In reply to comment #1)
> There are a *lot* of recipes that exceed 80 character lines, because this
> isn't 1970 anymore. :)
I guess the coding style guides haven't been updated since.
> A limit of something like 160 to check that recipes are not using giant
> lines is more realistic IMHO.
my full screen terminal can handle 279 chars yet every time I open a new terminal window it comes at 80 chars wide. I think it is better to stick to the standards but recipes could be a 'special' case.
Comment 5 Leonardo Sandoval Gonzalez 2017-03-14 18:47:24 UTC
Fixed by

http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe/commit/?id=cabfb858051a6eaa29d1fa6a6e39e558894f47c7

max length set to 160.