| Summary: | patchwork: failed to create new series revisions from emails in a thread | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Yocto Project Subprojects] Patchwork/Patchtest | Reporter: | Jose Lamego <jose.a.lamego> | ||||
| Component: | Patchwork | Assignee: | Jose Lamego <jose.a.lamego> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | Medium | CC: | bluelightning, leonardo.sandoval.gonzalez | ||||
| Version: | 2.3 | ||||||
| Target Milestone: | 2.3 M4 | ||||||
| Hardware: | x86 | ||||||
| OS: | Multiple | ||||||
| Whiteboard: | |||||||
| OS type for building Yocto: | --- | Type of Regression: | --- | ||||
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |||||
| Attachments: |
|
||||||
|
Description
Jose Lamego
2017-01-24 14:12:12 UTC
Preliminary finding: This issue may be caused by patchwork not appropriately handling a continuation patch (version N) that is sent with a x/n combination in subject (number/order) different to that in parent revision patch. Further analysis showed that this issue is caused by "reply-series" where patches in version 2 and up are created as replies only to their respective cover letter, and only this new cover letter includes the header that links to the original cover letter or series. Since Patchwork does not find a parent patch before creating a new revision, it attempts to add the new patch at the latest revision, which fails because there is already a patch in that order. This scenario should only occur when series are not created using the OE recommended patch submission procedure, however, it is worth developing a fix to deal with it. Fix developed is being tested at the staging instance: https://patchwork-staging.openembedded.org/ patch sent to the mailing list can be reviewed at: https://lists.yoctoproject.org/pipermail/yocto/2017-March/035414.html V2 patch send with a fixed typo (thanks Leo!): https://lists.yoctoproject.org/pipermail/yocto/2017-March/035415.html A couple more typos fixed in version 3: https://lists.yoctoproject.org/pipermail/yocto/2017-March/035429.html A version 4 includes considering possible cover letters only those messages with a Subject line starting with "[", filtering out reply or forwarded messages: https://lists.yoctoproject.org/pipermail/yocto/2017-April/035528.html Change pushed to production in commit: 0923e2a09d4a5d1ac2f9fce4b32b8d030efd7d90 |