Bug 10959 - patchwork: failed to create new series revisions from emails in a thread
Summary: patchwork: failed to create new series revisions from emails in a thread
Status: RESOLVED FIXED
Alias: None
Product: Patchwork/Patchtest
Classification: Yocto Project Subprojects
Component: Patchwork (show other bugs)
Version: 2.3
Hardware: x86 Multiple
: Medium normal
Target Milestone: 2.3 M4
Assignee: Jose Lamego
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2017-01-24 14:12 UTC by Jose Lamego
Modified: 2017-12-06 17:25 UTC (History)
2 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments
Messages in thread (97.24 KB, application/gzip)
2017-01-24 14:12 UTC, Jose Lamego
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Lamego 2017-01-24 14:12:12 UTC
Created attachment 3603 [details]
Messages in thread

Additional email messages were received for the patch series 4904, but patchwork didn't create new revisions.

Series in OE-patchwork:
https://patchwork.openembedded.org/series/4904/

first message in thread:
http://lists.openembedded.org/pipermail/openembedded-core/2017-January/131600.html

I'm attaching the messages in thread for reference.
Comment 1 Jose Lamego 2017-02-10 17:50:01 UTC
Preliminary finding: This issue may be caused by patchwork not appropriately handling a continuation patch (version N) that is sent with a x/n combination in subject (number/order) different to that in parent revision patch.
Comment 2 Jose Lamego 2017-03-21 23:04:45 UTC
Further analysis showed that this issue is caused by "reply-series" where patches in version 2 and up are created as replies only to their respective cover letter, and only this new cover letter includes the header that links to the original cover letter or series. Since Patchwork does not find a parent patch before creating a new revision, it attempts to add the new patch at the latest revision, which fails because there is already a patch in that order.
This scenario should only occur when series are not created using the OE recommended patch submission procedure, however, it is worth developing a fix to deal with it.
Comment 3 Jose Lamego 2017-03-30 20:13:09 UTC
Fix developed is being tested at the staging instance:
https://patchwork-staging.openembedded.org/

patch sent to the mailing list can be reviewed at:
https://lists.yoctoproject.org/pipermail/yocto/2017-March/035414.html
Comment 4 Jose Lamego 2017-03-30 20:42:57 UTC
V2 patch send with a fixed typo (thanks Leo!):
https://lists.yoctoproject.org/pipermail/yocto/2017-March/035415.html
Comment 5 Jose Lamego 2017-03-31 17:26:53 UTC
A couple more typos fixed in version 3:
https://lists.yoctoproject.org/pipermail/yocto/2017-March/035429.html
Comment 6 Jose Lamego 2017-04-06 16:02:57 UTC
A version 4 includes considering possible cover letters only those messages with a Subject line starting with "[", filtering out reply or forwarded messages:

https://lists.yoctoproject.org/pipermail/yocto/2017-April/035528.html
Comment 7 Jose Lamego 2017-04-17 16:39:24 UTC
Change pushed to production in commit:
0923e2a09d4a5d1ac2f9fce4b32b8d030efd7d90