| Summary: | check for four-space indented in python metadata | ||
|---|---|---|---|
| Product: | [Yocto Project Subprojects] Patchwork/Patchtest | Reporter: | Leonardo Sandoval Gonzalez <leonardo.sandoval.gonzalez> |
| Component: | Patchtest Testsuite | Assignee: | Daniela Plascencia <daniela.plascencia> |
| Status: | RESOLVED OBSOLETE | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | Medium | CC: | bluelightning, ross.burton |
| Version: | 2.4 | ||
| Target Milestone: | 2.5 M2 | ||
| Hardware: | x86 | ||
| OS: | Multiple | ||
| Whiteboard: | |||
| OS type for building Yocto: | --- | Type of Regression: | --- |
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |
|
Description
Leonardo Sandoval Gonzalez
2017-05-17 14:46:26 UTC
(In reply to comment #0) > According to [1] "Python functions must be four space indented - no tabs." > > [1] http://www.openembedded.org/wiki/Styleguide#Format_Guidelines There's a Pylint option that catches tab indentation. We are already using Pylint to test Python code and I think changing a couple parameters will do the work. Do you think a new check is needed? (In reply to comment #1) > (In reply to comment #0) > > According to [1] "Python functions must be four space indented - no tabs." > > > > [1] http://www.openembedded.org/wiki/Styleguide#Format_Guidelines > > There's a Pylint option that catches tab indentation. We are already using > Pylint to test Python code and I think changing a couple parameters will do > the work. Do you think a new check is needed? understood, then the pylint implementation should be the path to take. Changing to 2.5 M1. I'm planning to tackle most of the test-suite enhancements on such milestone. This is not a M+, and can be work on M2. The test already checks for indentation errors/inconsistencies, but this issue is now obsolete as the pylint test case has to be refactored. I'm filing a new issue for tracking the refactoring process. |