Bug 11519 - check for four-space indented in python metadata
Summary: check for four-space indented in python metadata
Status: RESOLVED OBSOLETE
Alias: None
Product: Patchwork/Patchtest
Classification: Yocto Project Subprojects
Component: Patchtest Testsuite (show other bugs)
Version: 2.4
Hardware: x86 Multiple
: Medium enhancement
Target Milestone: 2.5 M2
Assignee: Daniela Plascencia
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2017-05-17 14:46 UTC by Leonardo Sandoval Gonzalez
Modified: 2017-11-30 20:46 UTC (History)
2 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Leonardo Sandoval Gonzalez 2017-05-17 14:46:26 UTC
According to [1] "Python functions must be four space indented - no tabs."

[1] http://www.openembedded.org/wiki/Styleguide#Format_Guidelines
Comment 1 Daniela Plascencia 2017-05-18 15:04:23 UTC
(In reply to comment #0)
> According to [1] "Python functions must be four space indented - no tabs."
> 
> [1] http://www.openembedded.org/wiki/Styleguide#Format_Guidelines

There's a Pylint option that catches tab indentation. We are already using Pylint to test Python code and I think changing a couple parameters will do the work. Do you think a new check is needed?
Comment 2 Leonardo Sandoval Gonzalez 2017-05-18 15:07:16 UTC
(In reply to comment #1)
> (In reply to comment #0)
> > According to [1] "Python functions must be four space indented - no tabs."
> > 
> > [1] http://www.openembedded.org/wiki/Styleguide#Format_Guidelines
> 
> There's a Pylint option that catches tab indentation. We are already using
> Pylint to test Python code and I think changing a couple parameters will do
> the work. Do you think a new check is needed?

understood, then the pylint implementation should be the path to take.
Comment 3 Daniela Plascencia 2017-09-25 17:52:32 UTC
Changing to 2.5 M1. I'm planning to tackle most of the test-suite enhancements on such milestone.
Comment 4 Leonardo Sandoval Gonzalez 2017-10-20 14:45:23 UTC
This is not a M+, and can be work on M2.
Comment 5 Daniela Plascencia 2017-11-30 20:46:17 UTC
The test already checks for indentation errors/inconsistencies, but this issue is now obsolete as the pylint test case has to be refactored.
I'm filing a new issue for tracking the refactoring process.