| Summary: | Running diffconfig task from BitBake returns error | ||
|---|---|---|---|
| Product: | [Yocto Project Subprojects] Kernel | Reporter: | Scott Rifenbark <srifenbark> |
| Component: | kernel-tooling | Assignee: | Bruce Ashfield <bruce.ashfield> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Medium+ | CC: | leonardo.sandoval.gonzalez, pokylinux, randy.macleod, yp.kernel.watcher, yp.watcher |
| Version: | 2.4 | ||
| Target Milestone: | 2.4 M4 | ||
| Hardware: | x86 | ||
| OS: | Multiple | ||
| Whiteboard: | |||
| OS type for building Yocto: | --- | Type of Regression: | Regression (Used to work) |
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |
|
Description
Scott Rifenbark
2017-09-27 16:27:05 UTC
This commit broke the routine. diff returns '1' if there are differences and it isn't an error. So the switch to check_call is not right for this routine. I'll send patch to restore the old call. commit b090ff6a277aa6e242020d7d6ffb1d351e3ee4e0 Author: Mikko Rapeli <mikko.rapeli@bmw.de> Date: Thu Jun 22 16:23:14 2017 +0300 meta: Fix return value checks from subprocess.call()'s Python function subprocess.call() returns the return value of the executed process. If return values are not checked, errors may go unnoticed and bad things can happen. Change all callers of subprocess.call() which do not check for the return value to use subprocess.check_call() which raises CalledProcessError if the subprocess returns with non-zero value. https://docs.python.org/2/library/subprocess.html#using-the-subprocess-module All users of the function were found with: $ git grep "subprocess\.call" | \ egrep -v 'if.*subprocess\.call|=\ +subprocess\.call|return.*subprocess\.call' Tested similar patch on top of yocto jethro. Only compile tested core-image-minimal on poky master branch. (From OE-Core rev: 578c8205fd14c48c6d30ef2889d86f1b4aee060a) Signed-off-by: Mikko Rapeli <mikko.rapeli@bmw.de> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> :100644 100644 38e6613c486d... eb8e7907f602... M meta/classes/cml1.bbclass |