Bug 12628

Summary: MACHINE_EXTRA_RRECOMMEND syntax not the best
Product: [Build System, Metadata & Runtime] BSPs Reporter: Scott Rifenbark <srifenbark>
Component: bsps-configurationAssignee: Stephano Cetola <stephano>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Medium+ CC: randy.macleod, richard.purdie, stephano, yp.bsp.watcher, yp.watcher
Version: unspecified   
Target Milestone: 2.5 M4   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)

Description Scott Rifenbark 2018-03-26 14:35:46 UTC 
The machine configuration file for the BeagleBone BSP (https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf) has the following statement:

MACHINE_EXTRA_RRECOMMENDS = " kernel-modules kernel-devicetree"

This should probably be the following:

MACHINE_EXTRA_RRECOMMENDS += "kernel-modules kernel-devicetree"

The reason is because the string wants to use a space at the front, which assumes the value of the string is being appended to any current value of MACHINE_EXTRA_RRECOMMENDS. The "+=" operator will insert its own space when appending the string.  Another way would be to do the following:

MACHINE_EXTRA_RRECOMMENDS .= " kernel-modules kernel-devicetree"

I know this probably doesn't make much difference, but I am providing a detailed description of this particular machine configuration file in the BSP manual and it looks pretty poor.

Scott
Comment 2 Richard Purdie 2018-05-17 07:56:01 UTC 
Fixed in the above commit.
Comment 3 Scott Rifenbark 2018-05-17 11:11:29 UTC 
Also fixed in the manual now... 

Thanks
Scott

https://www.yoctoproject.org/docs/2.5/bsp-guide/bsp-guide.html#bsp-machine-configuration-example