Bug 12628 - MACHINE_EXTRA_RRECOMMEND syntax not the best
Summary: MACHINE_EXTRA_RRECOMMEND syntax not the best
Status: RESOLVED FIXED
Alias: None
Product: BSPs
Classification: Build System, Metadata & Runtime
Component: bsps-configuration (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 2.5 M4
Assignee: Stephano Cetola
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2018-03-26 14:35 UTC by Scott Rifenbark
Modified: 2018-05-17 11:11 UTC (History)
5 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Rifenbark 2018-03-26 14:35:46 UTC 
The machine configuration file for the BeagleBone BSP (https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf) has the following statement:

MACHINE_EXTRA_RRECOMMENDS = " kernel-modules kernel-devicetree"

This should probably be the following:

MACHINE_EXTRA_RRECOMMENDS += "kernel-modules kernel-devicetree"

The reason is because the string wants to use a space at the front, which assumes the value of the string is being appended to any current value of MACHINE_EXTRA_RRECOMMENDS. The "+=" operator will insert its own space when appending the string.  Another way would be to do the following:

MACHINE_EXTRA_RRECOMMENDS .= " kernel-modules kernel-devicetree"

I know this probably doesn't make much difference, but I am providing a detailed description of this particular machine configuration file in the BSP manual and it looks pretty poor.

Scott
Comment 2 Richard Purdie 2018-05-17 07:56:01 UTC 
Fixed in the above commit.
Comment 3 Scott Rifenbark 2018-05-17 11:11:29 UTC 
Also fixed in the manual now... 

Thanks
Scott

https://www.yoctoproject.org/docs/2.5/bsp-guide/bsp-guide.html#bsp-machine-configuration-example